Adding reset after measure if qubit is to be reused by 1tnguyen · Pull Request #3450 · NVIDIA/cuda-quantum

1tnguyen · 2025-09-19T06:38:37Z

Description

A pass to detect if qubit is to be reused after measurement. If so, insert a reset and conditional x gate based on measurement result in order to bring the qubit into the |0> or |1> state consistent with the measurement.
Add the pass to quantinuum target pipeline config.
Add tests.
Modify the resource counting pre-process pass: move it down the JIT pipeline as the removal of gates in that pass may interfere with the program flow detection (i.e., whether a qubit is reused or not).

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions · 2025-09-19T08:26:37Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

schweitzpgi

Will look at this more...

include/cudaq/Optimizer/Transforms/Passes.td

include/cudaq/Optimizer/Transforms/Passes.h

lib/Optimizer/Transforms/ResetBeforeReuse.cpp

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions · 2025-09-22T07:13:48Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-09-22T08:57:52Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions · 2025-09-24T05:12:15Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions · 2025-09-29T08:09:53Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions · 2025-10-14T20:56:22Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

test/AST-Quake/reset_after_measure.cpp

github-actions · 2025-10-23T00:14:53Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-10-28T05:09:43Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions · 2025-10-29T03:57:03Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-10-31T00:18:45Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen · 2025-10-31T20:35:52Z

This pass should be written when the IR is in explicit linear use form (aka, value semantics), as it will be much simpler to understand, write, etc.

It actually becomes trivial. A measurement op must produce 1 or more wires. If those wires are used by anything that is not a sink operation, they are reused. In those case, if the reuse is not a reset operation, then insert a reset operation. Done.

I posted #3565 to implement this pass in the linear SSA form.
In the linear form, we would also need to find a good solution for potential qubit wire aliasing, e.g., from qubit vector slicing.

Hence, it might be better to do it as a follow-on task.

schweitzpgi

Giving temporary approval. This ought to be re-done using the wire types.

github-actions · 2025-11-03T22:57:03Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2025-11-04T04:44:06Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

* Add reset after measurement Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Add test Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Handle reg Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Add test for register Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Add test Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Update lib/Optimizer/Transforms/ResetBeforeReuse.cpp Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com> * Update include/cudaq/Optimizer/Transforms/Passes.td Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com> * Update include/cudaq/Optimizer/Transforms/Passes.h Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com> * Use new MLIR pass util Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Tidy up the code Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Add execution test Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Fix CI tests Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Fix a test Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Some tidy up Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Code review: tidy up the code Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Code review: Rename test files following convention Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Code review: order filename Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Code review: refactor test files Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Add more tests, especially targeting aliasing Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Code review: more comprehensive checks Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> --------- Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

1tnguyen added 5 commits September 17, 2025 04:27

Add reset after measurement

52bd955

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Add test

5303586

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Handle reg

d10d971

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Add test for register

7ca7a9e

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Add test

18d1f36

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

1tnguyen changed the title ~~[WIP~~ [WIP] Adding reset after measure if qubit is to be reused Sep 19, 2025

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

e2b045d

github-actions bot pushed a commit that referenced this pull request Sep 19, 2025

Docs preview for PR #3450.

a48782d

schweitzpgi reviewed Sep 19, 2025

View reviewed changes

include/cudaq/Optimizer/Transforms/Passes.td Outdated Show resolved Hide resolved

include/cudaq/Optimizer/Transforms/Passes.h Outdated Show resolved Hide resolved

lib/Optimizer/Transforms/ResetBeforeReuse.cpp Outdated Show resolved Hide resolved

schweitzpgi reviewed Sep 19, 2025

View reviewed changes

lib/Optimizer/Transforms/ResetBeforeReuse.cpp Outdated Show resolved Hide resolved

1tnguyen and others added 5 commits September 22, 2025 14:19

Update lib/Optimizer/Transforms/ResetBeforeReuse.cpp

d28bc07

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

Update include/cudaq/Optimizer/Transforms/Passes.td

ce54750

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

Update include/cudaq/Optimizer/Transforms/Passes.h

1e13ba2

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

Use new MLIR pass util

9d2f0a3

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Tidy up the code

60d8d77

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions bot pushed a commit that referenced this pull request Sep 22, 2025

Docs preview for PR #3450.

a2db689

github-actions bot pushed a commit that referenced this pull request Sep 22, 2025

Docs preview for PR #3450.

ac0f191

1tnguyen added 2 commits September 24, 2025 01:36

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

442cff5

Add execution test

7db91b2

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions bot pushed a commit that referenced this pull request Sep 24, 2025

Docs preview for PR #3450.

c337a5b

1tnguyen added 2 commits September 29, 2025 02:37

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

87f3777

Fix CI tests

e032e93

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions bot pushed a commit that referenced this pull request Sep 29, 2025

Docs preview for PR #3450.

711cedb

Fix a test

df6f3c1

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

github-actions bot pushed a commit that referenced this pull request Sep 29, 2025

Docs preview for PR #3450.

5503d8c

github-actions bot pushed a commit that referenced this pull request Oct 14, 2025

Docs preview for PR #3450.

fe6b7bc

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

a27ded1

schweitzpgi reviewed Oct 22, 2025

View reviewed changes

test/AST-Quake/reset_after_measure.cpp Outdated Show resolved Hide resolved

github-actions bot pushed a commit that referenced this pull request Oct 23, 2025

Docs preview for PR #3450.

2147d88

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

f74f2a4

github-actions bot pushed a commit that referenced this pull request Oct 28, 2025

Docs preview for PR #3450.

654681d

1tnguyen and others added 2 commits October 29, 2025 02:14

Code review: more comprehensive checks

21211db

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

e53c57a

github-actions bot pushed a commit that referenced this pull request Oct 29, 2025

Docs preview for PR #3450.

300204e

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

505461d

github-actions bot pushed a commit that referenced this pull request Oct 31, 2025

Docs preview for PR #3450.

b08d9e7

1tnguyen mentioned this pull request Oct 31, 2025

Implement 'reset after measure' in value semantics (linear use form) #3565

Open

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

62966eb

schweitzpgi approved these changes Nov 3, 2025

View reviewed changes

github-actions bot pushed a commit that referenced this pull request Nov 3, 2025

Docs preview for PR #3450.

3f4b284

Merge branch 'main' into tnguyen/reset-after-measure-before-reuse

c744283

github-actions bot pushed a commit that referenced this pull request Nov 4, 2025

Docs preview for PR #3450.

54559f2

1tnguyen closed this Nov 4, 2025

github-actions bot pushed a commit that referenced this pull request Nov 4, 2025

Cleaning up docs preview for PR #3450.

4e56fcb

bettinaheim added the release notes Changes need to be captured in the release notes label Nov 25, 2025

bettinaheim added this to the release 0.13.0 milestone Nov 25, 2025

Conversation

1tnguyen commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

schweitzpgi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

1tnguyen commented Oct 31, 2025

Uh oh!

schweitzpgi left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

1tnguyen commented Sep 19, 2025 •

edited

Loading