Various fixes for dynamic kernel loading #3507
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
sacpis
reviewed
Oct 10, 2025
| } | ||
| target.platformName = foundPlatformName.value_or("default"); | ||
| target.simulatorName = foundSimulatorName.value_or("qpp"); | ||
| target.simulatorName = foundSimulatorName.value_or(""); |
There was a problem hiding this comment.
Does this mean the default won't be qpp simulator anymore? Just curious to know what would the default option be?
sacpis
reviewed
Oct 10, 2025
| target.simulatorName, target.platformName); | ||
| std::string simName = target.simulatorName; | ||
| if (simName.empty()) { | ||
| // This target doesn't a simulator defined, e.g., hardware targets. |
sacpis
reviewed
Oct 10, 2025
| if (simName.empty()) { | ||
| // This target doesn't a simulator defined, e.g., hardware targets. | ||
| // We still need a simulator in case of local emulation. | ||
| auto &defaultTargetInfo = targets[defaultTarget]; |
There was a problem hiding this comment.
Got it. Here is the default simulator.
There was a problem hiding this comment.
Yeah, without this, we're stuck with qpp for all hardware emulation when running on Python, e.g., cannot use stim for emulation of Clifford circuits.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(1) Allow override in
registerDeviceKernel(2) Clear kernel decorator's
module(parsed from walking the Python AST) as we switch target.The lack of this
moduleattribute tells the decorator to perform a propercompile().Note: Other global maps might be populated during kernel constructor (i.e., as Python sees kernels); hence might not be safe to clear.
(3) Python to honor the default simulator environment variable for hardware target emulation. It was hardcoded to
qppfor those targets that don't define a simulator.