[CI] Publishing pipeline fixes continued#3579
Conversation
Signed-off-by: Mitchell <mitch_dz@hotmail.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
…ach library. (#3575) Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
…channel, fix an issue with torch on cu13 (#3576) Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Install `python3-venv` Signed-off-by: Pradnya Khalate <148914294+khalatepradnya@users.noreply.github.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
* Use cu12 packages for CUDA 12 Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
8405d79 to
2e90157
Compare
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
left a comment
There was a problem hiding this comment.
Overall this PR looks good. Just have one comment. Thanks @khalatepradnya.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
| # For CUDA version 13, we need to use the nightly build. | ||
| # This is required because the stable build (as of v2.9.0) depends on cuBlas 13.0, | ||
| # while cuquantum-cu13 depends on cuBlas 13.1. |
There was a problem hiding this comment.
Wow, I assume we need to make a similar change to CUDA-QX? Will this need to go int the docs?
There was a problem hiding this comment.
Definitely. I'll update the doc in a follow-up PR. Currently, it has a similar note about using the torch nightly channel for CUDA 12.8. I'll check whether it's still needed and add a note for CUDA 13.
There was a problem hiding this comment.
while cuquantum-cu13 depends on cuBlas 13.1.
I do not see this dependency. When I install in a fresh environment, the pipdeptree that I see is this:
cuquantum-cu13==25.9.0
├── custatevec-cu13 [required: ==1.10.0, installed: 1.10.0]
├── cutensornet-cu13 [required: ==2.9.0, installed: 2.9.0]
│ └── cutensor-cu13 [required: >=2.3.1,<3, installed: 2.3.1]
└── cudensitymat-cu13 [required: ==0.3.0, installed: 0.3.0]
├── cutensor-cu13 [required: >=2.3.1,<3, installed: 2.3.1]
└── cutensornet-cu13 [required: ~=2.9, installed: 2.9.0]
└── cutensor-cu13 [required: >=2.3.1,<3, installed: 2.3.1]
Where do you see that cuquantum-cu13 requires cuBlas 13.1?
And the prerequisites that I see on https://docs.nvidia.com/cuda/cuquantum/latest/custatevec/index.html simply say 12.x and 13.x for CUDA 12 and 13, respectively.
There was a problem hiding this comment.
I do, on the other hand, see where we/CUDA-Q are declaring a dependency on 13.1, but perhaps we shouldn't be doing that?
cuda-quantum/pyproject.toml.cu13
Line 25 in 9336ee2
There was a problem hiding this comment.
I think #3589 needs to be incorporated to address the Torch issue. That allows us to use a released version of Torch rather than forcing our users to use a nightly version of Torch.
bmhowe23
left a comment
There was a problem hiding this comment.
LGTM, but it wouldn't hurt my feelings if @bettinaheim reviewed, too.
|
Merging to facilitate package creation... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Ref: #3579 (comment) * ✅ Deployment: https://github.com/NVIDIA/cuda-quantum/actions/runs/19187271254 * ✅ Publishing: https://github.com/NVIDIA/cuda-quantum/actions/runs/19196197722 Required by: NVIDIA/cudaqx#350 This allows our users to use a released version of Torch rather than forcing them to use a nightly build.
…A#3589) Ref: NVIDIA#3579 (comment) * ✅ Deployment: https://github.com/NVIDIA/cuda-quantum/actions/runs/19187271254 * ✅ Publishing: https://github.com/NVIDIA/cuda-quantum/actions/runs/19196197722 Required by: NVIDIA/cudaqx#350 This allows our users to use a released version of Torch rather than forcing them to use a nightly build.
This PR follows-up the work from #3544
Successful pipeline - https://github.com/NVIDIA/cuda-quantum/actions/runs/19126706667
12.4.0,13.0.2) for conda channel selection for compatibility with available CUDA packagessetup.pyby including CUDA 13 library names, ensuring correct identification of the environment. (python/metapackages/setup.py)cudaq/__init__.pyto dynamically construct and set theCUDAQ_DYNLIBSenvironment variable based on the detected CUDA version, supporting both CUDA 12 and CUDA 13 and handling missing libraries gracefully. (python/cudaq/__init__.py)docker/release/cudaq.ext.Dockerfile)scripts/validate_container.sh,docs/notebook_validation.py)python3-venv,python3-pip) to the publishing workflow setup to ensure required tools are available for builds and validation. (.github/workflows/publishing.yml).0patch version in the channel name (conda 13.0.0 channel is not a real CUDA 13 channel); (2) install torch (during validation) matching the version of cuda-q wheel dependencies (prevent conflicting dependencies).