Removing cuda-mlir-runtime dependency on nvqir.#4008
Merged
Renaud-K merged 1 commit intoNVIDIA:mainfrom Feb 19, 2026
Merged
Conversation
Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>
atgeller
reviewed
Feb 19, 2026
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was coupling between the compiler
cuda-mlir-runtimeand the resource count simulatornvqirbecause the compiler was trying to directly update the resource count of the simulator. With these changes the resource counts are passed as a return value of the compiler and the resource count simulator is updated in the QPU.The
KernelExecutionhas now an additionalResourcesfield and certainly shows that it is being overloaded as a return value but this will have to be addressed by other refactors when compilation is broken up into different policies which can then have different return types.nvqirwas publicly linking* withcuda-commonand other libraries andcuda-mlir-runtimewas publicly linkingnvqir. Removing the dependency onnvqirmeans that existing dependencies have to be made explicit. Socuda-mlir-runtimestill depends oncudaq-commonfor resouce counts, device code registry and other utilities and the dependency between QPUs andnvqiris now apparent.