Conversation
Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>
|
We had already settled on a namespace of I think @khalatepradnya had a PR to standardize that once upon a time, and there are all manner of "alternative spellings" IIRC. |
It was this PR #2946. |
|
|
It occurred to me that under this proposal, it is still not quite clear to users whether they are accessing internal functionality or not. There is the possibility that internal headers are included transitively. In this case nothing can really prevent a user from using an internal class. For instance:
I believe this means that we need to introduce a
cudaq_internalnamespace along with thecudaq_internalroot for header files.This is what this PR is proposing.
Along with it, I am adding guidelines from the LLVM coding standard which are relevant.