[WIP] Restoring backward ABI compatibility with cudaq_solver 0.5.0#4104
Closed
Renaud-K wants to merge 1 commit intoNVIDIA:mainfrom
Closed
[WIP] Restoring backward ABI compatibility with cudaq_solver 0.5.0#4104Renaud-K wants to merge 1 commit intoNVIDIA:mainfrom
Renaud-K wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>
Renaud-K
changed the title
Renaud-K
commented
Mar 6, 2026
| { | ||
| "cell_type": "code", | ||
| "execution_count": 1, | ||
| "execution_count": null, |
Collaborator
Author
There was a problem hiding this comment.
Did not mean to have this. Not sure how it got there.
Collaborator
There was a problem hiding this comment.
Seems like you missed to save the notebook after running it?
Collaborator
There was a problem hiding this comment.
doesn't matter either way - this is something that would be nice to add some scripts for to "sanitize" how notebooks are checked in at some point.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Collaborator
Author
|
We will not be insuring ABI compatibility between for cudaq 0.14.0 and cudaqx 0.5.0. |
schweitzpgi
reviewed
Mar 6, 2026
| } | ||
|
|
||
| bool quantum_platform::is_simulator(std::size_t qpu_id) const { | ||
| bool quantum_platform::is_simulator(const std::size_t qpu_id) const { |
Collaborator
There was a problem hiding this comment.
Just curious: were these arguments declared const previously?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.