Create executeKernel function in PythonLauncher#4136
Queued
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
Queued
Create executeKernel function in PythonLauncher#4136lmondada wants to merge 2 commits intoNVIDIA:mainfrom
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Luca Mondada <luca@mondada.net>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
approved these changes
Mar 11, 2026
Collaborator
schweitzpgi
left a comment
schweitzpgi
left a comment
There was a problem hiding this comment.
Seems like a reasonable refactor. Thanks, Luca.
I'll message you in a follow-up. :)
Signed-off-by: Luca Mondada <luca@mondada.net>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was resolving merge conflicts for #4052 and wanted to make sure I got it right. I am opening this PR as an in-between step.
This PR does not change any code logic, it just refactors the "execute kernel" part of
PythonLauncher::launchModuleinto a separate function. Actually, no, there is one change: the message "Loading previously compiled JIT engine for {}" etc is only printed whenisPersistingJITEngineis true. I am pretty sure that's the desired behaviour.Finally, I've noticed that when
hasVariationalArgsis true, the argument buffer as a whole is passed to the thunk function, whereas otherwise it is only its last argument. Is it because there can never be arguments passed whenhasVariationalArgsis true?