fix(core): stop recommending maxBytesInFlight - #2107
Open
WilliamK112 wants to merge 4 commits into
Open
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
…es-in-flight-recommendation Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com> # Conflicts: # core/src/main/scala/com/nvidia/spark/rapids/tool/tuning/AutoTuner.scala
WilliamK112
marked this pull request as ready for review
August 22, 2026 18:32
parthosa
self-requested a review
August 25, 2026 15:24
parthosa
previously approved these changes
Aug 25, 2026
parthosa
dismissed
their stale review
August 25, 2026 17:09
Revoking approval pending merge conflict resolution.
…es-in-flight-recommendation Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com> # Conflicts: # core/src/main/scala/com/nvidia/spark/rapids/tool/tuning/AutoTuner.scala
Author
|
Resolved the merge conflict in 94995bd by merging the latest Validation (JDK 17): Result: 200 tests passed, 0 failed (7 ignored). |
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes the AutoTuner recommendation for
spark.rapids.shuffle.multiThreaded.maxBytesInFlight.Why
Fixes #1710. The issue notes that this recommendation should be removed because it does not use metrics to make the decision, and the issue discussion has maintainer confirmation to remove it.
Details
MAX_BYTES_IN_FLIGHTtuning config and recommendation path fromAutoTuner.maxBytesInFlightrecommendation flag.devbranch while preserving the new PySpark memory-rebalancing logic.Validation
git diff --checkcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.ProfilingAutoTunerSuiteV2 test— 64 passedcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.QualificationAutoTunerSuite test— 48 passedcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.ProfilingAutoTunerSuite test— 152 passed, 7 ignoredcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.config.PySparkMemoryTuningPolicySuite test— 7 passedcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DskipTests verify— build and Scalastyle passed (314 files, 0 errors, 0 warnings)