fix(user_tools): download explicit tools jar - #2108
Open
WilliamK112 wants to merge 2 commits into
Open
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
github-actions
Bot
added
the
user_tools
…cit-tools-jar Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
WilliamK112
marked this pull request as ready for review
August 22, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--tools_jarfrom the default wheel-provided tools JARgs://valuesRoot cause
When
use_local_tools_jar()was true,_process_jar_arg()used the current JAR path directly without checking whether the user had supplied--tools_jar. A remote JAR URL could therefore flow into the Java classpath unchanged, causing Java to fail to load the tools main class.Fixes #1889.
Validation
PYTHONPATH=src python -m pytest -q tests/spark_rapids_tools_ut/test_path_boundary.py(12 passed)PYTHONPATH=src python -m pytest -q tests/spark_rapids_tools_ut/test_tool_argprocessor.py -k test_with_platform_with_eventlogs_with_jar_files(12 passed, 127 deselected)python -m pylint -d fixme --load-plugins pylint_pydantic --rcfile=../.pylintrc src/spark_rapids_pytools/rapids/rapids_tool.py tests/spark_rapids_tools_ut/test_path_boundary.py(10.00/10)python -m flake8 src/spark_rapids_pytools/rapids/rapids_tool.py tests/spark_rapids_tools_ut/test_path_boundary.pypython -m py_compile src/spark_rapids_pytools/rapids/rapids_tool.py tests/spark_rapids_tools_ut/test_path_boundary.pygit diff --check upstream/dev...HEAD