Migrate CollectTimeIterator to use new NvtxIdWithMetrics class#12900
Merged
Conversation
Signed-off-by: Zach Puller <zpuller@nvidia.com>
Signed-off-by: Zach Puller <zpuller@nvidia.com>
Signed-off-by: Zach Puller <zpuller@nvidia.com>
Signed-off-by: Zach Puller <zpuller@nvidia.com>
zpuller
commented
Jun 10, 2025
Signed-off-by: Zach Puller <zpuller@nvidia.com>
sameerz
added
the
task
Signed-off-by: Zach Puller <zpuller@nvidia.com>
Collaborator
Author
|
build |
abellina
reviewed
Oct 13, 2025
Signed-off-by: Zach Puller <zpuller@nvidia.com>
abellina
reviewed
Oct 13, 2025
abellina
reviewed
Oct 13, 2025
Signed-off-by: Zach Puller <zpuller@nvidia.com>
abellina
approved these changes
Oct 13, 2025
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are in the process of migrating all of our nvtx ranges to use the new documented Nvtx api. Many of the existing ranges are already wrapped in other classes such as the
NvtxWithMetricsclass. This pr establishes a replacement forNvtxWithMetricscalledNvtxIdWithMetricswhich provides the same wrapping functionality, but using the documented Nvtx class as input. Then, the PR begins migrating some of the many uses of this wrapper, namely the ranges that go through theCollectTimeIterator