[auto-merge] branch-25.10 to branch-25.12 [skip ci] [bot]#13529
Merged
Conversation
This changes the plugin to call the new spark-rapids-jni API for rounding rather than the old cudf API. The rounding of floating point functionality will be removed from cudf so we've moved the float rounding (and the API) into spark-rapids-jni. This is part of resolving [sr-jni issue 3585](NVIDIA/cudf-spark-jni#3585) [This PR](rapidsai/cudf#20110) removes the old java code from cudf, and will be merged in cudf 25.12. [This PR](NVIDIA/cudf-spark-jni#3770) moves the floating rounding into spark-rapids-jni and changes the API. This will be merged in 25.10 and is a dependency of this PR. Note that I have tested this code applying both of the above PRs and all of the spark-rapids integration tests pass. ### Checklists - [ ] This PR has added documentation for new or modified features or behaviors. - [ ] This PR has added new tests or modified existing tests to cover new code paths. (Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.) - [ ] Performance testing has been performed and its results are added in the PR description. Or, an issue has been filed with a link in the PR description. --------- Signed-off-by: Paul Mattione <pmattione@nvidia.com>
Collaborator
Author
|
SUCCESS - auto-merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto-merge triggered by github actions on
branch-25.10to create a PR keepingbranch-25.12up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.