[auto-merge] branch-25.10 to branch-25.12 [skip ci] [bot]#13534
Merged
Conversation
Fixes #13531 ### Description In OSS Delta 3.x, IncrementMetric is used to count the number of rows passing through it. It is used for metrics like `numTargetRowsInserted`. In 2.4- it is implemented using a UDF for which we provide a GPU version https://github.com/NVIDIA/spark-rapids/blob/7a894deb90f53308aa75b0065a4813ff95b7753a/delta-lake/delta-24x/src/main/scala/org/apache/spark/sql/delta/rapids/delta24x/GpuMergeIntoCommand.scala#L1133-L1141. The reason for a change on the CPU side is to make it codegen-able. spark-rapids just needs an equivalent implementation for it to avoid a CPU fallback with a ColumnarToRow penalty. #### Benchmarks cloned `store_sales` from the SF10 TPC-DS dataset Merge the original table into the shallow-cloned table updating a varying number of rows: 5%, 10%, 20%, 40%, 100% ```SQL MERGE INTO delta.`/path/store_sales.cloned` AS target USING delta.`/path/store_sales` AS source ON target.ss_ticket_number = source.ss_ticket_number AND target.ss_item_sk = source.ss_item_sk AND (source.ss_ticket_number * source.ss_item_sk) % 1000 < 400 WHEN MATCHED THEN UPDATE SET target.ss_coupon_amt = source.ss_coupon_amt; ``` Match % | 25.10 pre-PR | 25.10 post-PR | Speedup -- | -- | -- | -- 100% | 41 | 25 | 1.64 40% | 39 | 26 | 1.5 20% | 39 | 26 | 1.5 10% | 40 | 26 | 1.538461538 5% | 41 | 26 | 1.576923077 ### Checklists - [ ] This PR has added documentation for new or modified features or behaviors. - [ ] This PR has added new tests or modified existing tests to cover new code paths. (Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.) - [x] Performance testing has been performed and its results are added in the PR description. Or, an issue has been filed with a link in the PR description. --------- Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Collaborator
Author
|
SUCCESS - auto-merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto-merge triggered by github actions on
branch-25.10to create a PR keepingbranch-25.12up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.