Skip to content

Move common shim helpers to shared sources#15052

Merged
gerashegalov merged 0 commit into
codex/unshim-stack-02q-remaining-callersfrom
codex/unshim-stack-02r-common-shim-helpers
Jun 10, 2026
Merged

Move common shim helpers to shared sources#15052
gerashegalov merged 0 commit into
codex/unshim-stack-02q-remaining-callersfrom
codex/unshim-stack-02r-common-shim-helpers

Conversation

@gerashegalov

@gerashegalov gerashegalov commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Related to #14834.

Description

This PR is one reviewable layer in the unshim stack introduced by #15025. It moves common shim helper implementations into shared sources now that callers have been adapted. This is the bridge between caller migration and deleting old shim-local copies.

Stack context

Testing and validation notes

  • No standalone behavior change is intended in this layer. It is covered by the full-stack packaging/build validation described in Add default common unshim packaging flow #15025 and the existing tests for the affected subsystem.
  • The full split stack was verified to be tree-equivalent to the pre-split stack top.

Checklists

Documentation

  • Updated for new or modified user-facing features or behaviors
  • No user-facing change

Testing

  • Added or modified tests to cover new code paths
  • Covered by existing tests
    (Covered by the validation notes in the PR description.)
  • Not required

Performance

  • Tests ran and results are added in the PR description
  • Issue filed with a link in the PR description
  • Not required

@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from b7a2605 to f6e6ac4 Compare June 10, 2026 20:49
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02r-common-shim-helpers branch 2 times, most recently from 3aedcbc to 543d7d8 Compare June 10, 2026 21:13
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from f6e6ac4 to 34804ee Compare June 10, 2026 21:13
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02r-common-shim-helpers branch 2 times, most recently from 8f6db57 to c80d61c Compare June 10, 2026 21:36
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from 19f0ac5 to bd7c6fb Compare June 10, 2026 21:36
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02r-common-shim-helpers branch from c80d61c to ddfb246 Compare June 10, 2026 22:20
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from 86e001e to 505e2e5 Compare June 10, 2026 22:37
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02r-common-shim-helpers branch 2 times, most recently from 19375c6 to c271777 Compare June 10, 2026 22:41
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from 505e2e5 to 7cc1e13 Compare June 10, 2026 22:41
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02r-common-shim-helpers branch 2 times, most recently from 91a33db to ce1c95c Compare June 10, 2026 23:12
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from 0ae48f8 to 4356413 Compare June 10, 2026 23:12
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02r-common-shim-helpers branch 2 times, most recently from b91960c to 6a596b3 Compare June 10, 2026 23:33
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from 179e067 to 81b157f Compare June 10, 2026 23:33
@gerashegalov gerashegalov merged commit 1c18cb3 into main Jun 10, 2026
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02q-remaining-callers branch from 81b157f to 31fb4c7 Compare June 10, 2026 23:48
@gerashegalov gerashegalov force-pushed the codex/unshim-stack-02r-common-shim-helpers branch from 6a596b3 to 1c18cb3 Compare June 10, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant