[WIP] Unshim Iceberg reader and delete helpers [fast-ut][reduced-it] - #15826
Draft
gerashegalov wants to merge 9 commits into
Draft
[WIP] Unshim Iceberg reader and delete helpers [fast-ut][reduced-it]#15826gerashegalov wants to merge 9 commits into
gerashegalov wants to merge 9 commits into
Conversation
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15821.
Stacked on #15824.
Description
Continue reducing special root-layout treatment for Iceberg by grouping several small, closely related helper refactors:
iceberg-commonmodule.GpuDeleteFileInfocompanion.dist/unshimmed-common-from-single-shim.txt.The logic is unchanged. Root-safe helpers are now emitted directly at the jar root, while helpers tied to Iceberg implementation classes remain in the selected parallel world.
AI assistance: Codex assisted with implementation and validation. The author reviewed the complete diff and this description before the PR was updated.
TODO before marking ready for review:
Validation:
iceberg-commonfor Spark 3.3.0, 3.5.7, 4.0.0, and 4.1.2.GpuDeleteFilterSuite: 6 tests passed.GpuPostProcessorSuite: 18 tests passed.IcebergDeletionVectorSuite: 5 tests passed.Performance: Not required because this change only relocates helpers or changes their owning companion without changing algorithms, data flow, or executed operations.
Checklists
Documentation
Testing
(
GpuDeleteFilterSuite,GpuPostProcessorSuite, andIcebergDeletionVectorSuite.)Performance