Skip to content

Move Hybrid scan internals out of the experimental namespace - #24940

Open
mhaseeb123 wants to merge 7 commits into
NVIDIA:mainfrom
mhaseeb123:hybrid-scan-internals-move
Open

mhaseeb123 wants to merge 7 commits into
NVIDIA:mainfrom
mhaseeb123:hybrid-scan-internals-move

Conversation

@mhaseeb123

@mhaseeb123 mhaseeb123 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

This trivial PR moves the Parquet hybrid scan internals from src/io/parquet/experimental to src/io/parquet/hybrid_scan. New namespace: cudf::io::parquet::hybrid_scan::detail (internals).

Checklist

  • I am familiar with the Contributing Guidelines.
  • Existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Oct 29, 2026
@mhaseeb123 mhaseeb123 added feature request New feature or request improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change and removed feature request New feature or request labels Oct 29, 2026
@mhaseeb123 mhaseeb123 changed the title Move Parquet hybrid scan internals out of the experimental namespace Move Hybrid scan internals out of the experimental namespace Oct 29, 2026
@mhaseeb123
mhaseeb123 marked this pull request as ready for review October 30, 2026 00:36
@mhaseeb123
mhaseeb123 requested review from a team as code owners October 30, 2026 00:36
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: NVIDIA/cudf
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 2b28962
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 31535d40-954b-4f47-9da2-be65efed1615
Commits

Reviewing files that changed from the base of the PR and between 5ed99b6 and 68c092a.

Files selected for processing: 1
  • cpp/src/io/parquet/hybrid_scan/page_index_filter.cu
Files skipped from review as they are similar to previous changes: 1
  • cpp/src/io/parquet/hybrid_scan/page_index_filter.cu

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Summary

Summary by CodeRabbit

  • Refactor
    • Reorganized the internal implementation of Parquet hybrid scanning into a dedicated area. The public interface and scanning behavior remain unchanged, so existing workflows for reading Parquet data continue to work as before. No changes to hybrid scan inputs or data flow are included.

Hybrid-scan implementation files move into a dedicated source directory and internal namespace. The public experimental namespace remains unchanged. Constructor inputs and forwarding behavior remain unchanged.

Changes: Hybrid-scan relocation

Layer / File(s) Summary
Update hybrid-scan declarations
cpp/include/cudf/io/experimental/hybrid_scan*.hpp, cpp/src/io/parquet/hybrid_scan/*_helpers.hpp, cpp/src/io/parquet/hybrid_scan/hybrid_scan_impl.hpp, cpp/src/io/parquet/hybrid_scan/page_index_filter_utils.hpp
Implementation pointers, forward declarations, and helper declarations now use cudf::io::parquet::hybrid_scan::detail.
Relocate implementation and build entries
cpp/CMakeLists.txt, cpp/src/io/parquet/experimental/hybrid_scan*.cpp, cpp/src/io/parquet/hybrid_scan/*
Implementation definitions and constructor references use the new detail namespace. The CMake source list uses the hybrid-scan directory for the relocated sources.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related issues

  • NVIDIA/cudf#24852: This PR relocates hybrid-scan internals but does not change reader behavior or implement the default-reader change and its follow-ups.

Suggested reviewers: cryos

Merge Risk: Minimal · up to 68c09

No merge-blocking issue is identified; merge after normal build and test checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the main change: moving Parquet hybrid scan internals out of the experimental namespace. The raw summary and the description confirm the move from src/io/parquet/experimental to src/io…
Description check Passed The description states that the PR moves Parquet hybrid scan internals from src/io/parquet/experimental to src/io/parquet/hybrid_scan and names the new namespace cudf::io::parquet::hybrid_scan::detail…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: moving Parquet hybrid scan internals out of the experimental namespace. The raw summary and the description confirm the move from src/io/parquet/experimental to src/io/parquet/hybrid_scan and the new cudf::io::parquet::hybrid_scan::detail namespace. The title is specific and matches the changeset.

Full details: Description check

Explanation

The description states that the PR moves Parquet hybrid scan internals from src/io/parquet/experimental to src/io/parquet/hybrid_scan and names the new namespace cudf::io::parquet::hybrid_scan::detail. This directly describes the changeset, so the check passes.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 14 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants