Fixed integer overflow in make_cute_packed_stride batch stride computation#3307
Open
a123pal wants to merge 1 commit into
Open
Fixed integer overflow in make_cute_packed_stride batch stride computation#3307a123pal wants to merge 1 commit into
a123pal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: make_cute_packed_stride computes the batch stride as get<0>(shape_MKL) * get<1>(shape_MKL) where both operands are int32. For large matrix dimensions (e.g. 49152 × 65536 = 3,221,225,472) this overflows int32 before the cast to IntT occurs, producing a negative batch stride.
Fix: Cast each operand to
IntTbefore multiplying so the multiplication occurs in 64-bit space. Applied to both affected overloads.Fixes #3269