[snap_service] Adds snap_service plugin#64
Merged
Conversation
filanov
reviewed
Jun 12, 2025
filanov
reviewed
Jun 12, 2025
filanov
reviewed
Jun 12, 2025
arel64
force-pushed
the
feature/snap_service_plugin
branch
from
June 12, 2025 15:05
0a9c33f to
d9c1f8f
Compare
filanov
reviewed
Jun 12, 2025
shai-malin
reviewed
Jun 12, 2025
shai-malin
left a comment
There was a problem hiding this comment.
Thanks Arel, looks good, just minor comments.
kghanayem
reviewed
Jun 15, 2025
| - runtime spdk information | ||
| """ | ||
|
|
||
| short_desc = "NVIDIA snap service" |
There was a problem hiding this comment.
The official name is "NVIDIA DOCA SNAP-4"
|
LGMT!, shared small comments |
Signed-off-by: Arel Sharon <arels@nvidia.com>
arel64
force-pushed
the
feature/snap_service_plugin
branch
from
June 15, 2025 13:55
d9c1f8f to
e514ecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines