Skip to content

[snap_service] Adds snap_service plugin#64

Merged
filanov merged 1 commit into
NVIDIA:mainfrom
arel64:feature/snap_service_plugin
Jun 15, 2025
Merged

[snap_service] Adds snap_service plugin#64
filanov merged 1 commit into
NVIDIA:mainfrom
arel64:feature/snap_service_plugin

Conversation

@arel64

@arel64 arel64 commented Jun 12, 2025

Copy link
Copy Markdown

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line? NO
  • Are all passwords or private data gathered by this PR obfuscated? N/A

Comment thread sos/report/plugins/snap_service.py
Comment thread sos/report/plugins/snap_service.py
Comment thread sos/report/plugins/snap_service.py
@arel64
arel64 force-pushed the feature/snap_service_plugin branch from 0a9c33f to d9c1f8f Compare June 12, 2025 15:05
Comment thread sos/report/plugins/snap_service.py Outdated

@shai-malin shai-malin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arel, looks good, just minor comments.

Comment thread sos/report/plugins/snap_service.py
Comment thread sos/report/plugins/snap_service.py
Comment thread sos/report/plugins/snap_service.py Outdated
- runtime spdk information
"""

short_desc = "NVIDIA snap service"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official name is "NVIDIA DOCA SNAP-4"

@kghanayem

Copy link
Copy Markdown

LGMT!, shared small comments

Signed-off-by: Arel Sharon <arels@nvidia.com>
@arel64
arel64 force-pushed the feature/snap_service_plugin branch from d9c1f8f to e514ecf Compare June 15, 2025 13:55
@filanov
filanov merged commit c2752fe into NVIDIA:main Jun 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants