fix(chart): mount mTLS CA for auth-callout#28
Draft
FrankSpitulski wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Frank Spitulski <fspitulski@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mtlsCAchart values for mounting CA Secretsdeploy/nats-event-buswhenglobal.eventBus.mtls.enabledis trueValidation
helm template dsx deploy/nats-event-bus --set global.eventBus.mtls.enabled=truerendered emptymtls.ca-pathand no auth-calloutmtls-cavolume before the fixhelm templateassertions for mTLS enabled, disabled, standalone auth-callout defaults, standalonemtlsCA.enabled, old manual workaround values, and customserviceConfig.mtls.ca-pathhelm lint auth-callout/deployhelm lint deploy/nats-event-busgit diff --checkmake checkmake -C local deploy-nats/etc/mtls-ca/ca.crtand deployments mountmtls-caMQTT_MTLS_BROKER=ssl://localhost:18883 go test -count=1 -v ./tests/functional -run TestMTLSConnection/ConnectWithMTLS -timeout 30sNotes
172.18.200.1:8883still timed out in the focused functional test; this branch verified the auth-callout CA path through directnats-mtlsservice access, and Gateway route behavior is covered by the separate mTLS route work.