Skip to content

fix(auth-callout): remove configmap seed config#50

Open
FrankSpitulski wants to merge 1 commit into
mainfrom
codex/remove-configmap-seed-config
Open

fix(auth-callout): remove configmap seed config#50
FrankSpitulski wants to merge 1 commit into
mainfrom
codex/remove-configmap-seed-config

Conversation

@FrankSpitulski
Copy link
Copy Markdown
Collaborator

@FrankSpitulski FrankSpitulski commented May 29, 2026

Summary

  • Remove NATS seed fields from auth-callout serviceConfig defaults and docs.
  • Document NATS seed material through AUTH_CALLOUT_NATS_* environment variables or a mounted secret config file.
  • Move standalone devspace seed injection from serviceConfig to env vars.

Validation

  • go test -count=1 ./... from auth-callout/
  • helm lint auth-callout/deploy
  • helm template test-release auth-callout/deploy
  • helm template devspace auth-callout/deploy with AUTH_CALLOUT_NATS_* extraEnvs renders successfully
  • helm dependency build deploy/nats-event-bus
  • helm lint deploy/nats-event-bus
  • helm template csc deploy/nats-event-bus -f local/nats/k8s/local-dev-values.yaml -f local/nats/k8s/csc/values.yaml --show-only charts/auth-callout/templates/configmap.yaml

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 29, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@FrankSpitulski FrankSpitulski changed the title [codex] Reject auth-callout ConfigMap seed config fix(auth-callout): reject configmap seed config May 29, 2026
@FrankSpitulski FrankSpitulski force-pushed the codex/remove-configmap-seed-config branch 2 times, most recently from c239d98 to 7437afe Compare May 29, 2026 20:37
@FrankSpitulski FrankSpitulski changed the title fix(auth-callout): reject configmap seed config fix(auth-callout): remove configmap seed config May 29, 2026
@FrankSpitulski FrankSpitulski force-pushed the codex/remove-configmap-seed-config branch from 7437afe to b2ee792 Compare May 29, 2026 20:42
Signed-off-by: Frank Spitulski <fspitulski@nvidia.com>
@FrankSpitulski FrankSpitulski force-pushed the codex/remove-configmap-seed-config branch from b2ee792 to db927c6 Compare May 29, 2026 21:08
@FrankSpitulski FrankSpitulski marked this pull request as ready for review May 29, 2026 21:10
@FrankSpitulski FrankSpitulski requested a review from a team May 29, 2026 21:10
@github-actions
Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-05-29 21:11:21 UTC | Commit: db927c6

@FrankSpitulski FrankSpitulski enabled auto-merge (squash) May 29, 2026 21:11
@github-actions
Copy link
Copy Markdown

🛡️ CodeQL Analysis

✅ No security issues found!

💡 Note: Enable GitHub Advanced Security to see full details in the Security tab.

🕐 Last updated: 2026-05-29 21:12:28 UTC | Commit: db927c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant