DLESyM notebook example #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pzharrington merged 7 commits into NVIDIA:main from pzharrington:dlesym-example

May 14, 2025

Collaborator

pzharrington commented May 9, 2025 •

edited

Loading

Earth2Studio Pull Request

Description

Add a simple notebook example demonstrating DLESyM usage.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.
The CHANGELOG.md is up to date with these changes.
An issue is linked to this pull request.

Dependencies


          draft dlesym example

c1ae99a

pzharrington self-assigned this

pzharrington marked this pull request as draft

May 9, 2025 17:30

pzharrington added 3 commits

May 9, 2025 10:39


          update interpolation

e563c9f


          DLESyM example complete, add NGC package

6dd6b16


          Merge branch 'main' into dlesym-example

62f92e6

pzharrington marked this pull request as ready for review

May 13, 2025 23:03

Collaborator Author

pzharrington commented May 13, 2025

/blossom-ci

pzharrington requested a review from NickGeneva

May 13, 2025 23:05


          Merge branch 'main' into dlesym-example

Collaborator Author

pzharrington commented May 14, 2025

/blossom-ci


          drop duplicate sst in arco

0cb4c57

Collaborator Author

pzharrington commented May 14, 2025

/blossom-ci

NickGeneva reviewed

View reviewed changes

earth2studio/models/px/dlesym.py Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

earth2studio/models/px/dlesym.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

earth2studio/models/px/dlesym.py Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

earth2studio/models/px/dlesym.py Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

earth2studio/models/px/dlesym.py Show resolved Hide resolved

Collaborator

NickGeneva commented May 14, 2025

LGTM, going to pull and try running the example myself rq

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Show resolved Hide resolved

Collaborator

NickGeneva commented May 14, 2025

Random note in case this comes up again:

Had to install sudo apt-get install python3-dev to build earth2grid

fatal error: Python.h: No such
      file or directory
         12 | #include <Python.h>
            |          ^~~~~~~~~~
      compilation terminated.
      ninja: build stopped: subcommand failed.

NickGeneva reviewed

View reviewed changes

earth2studio/models/px/dlesym.py Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

NickGeneva reviewed

View reviewed changes

examples/14_dlesym_example.py Outdated Show resolved Hide resolved

Collaborator

NickGeneva commented May 14, 2025

Example looks fantastic! added some minor changes needed.

Use make docs to test yourself to see if the rst looks good. This is great

NickGeneva approved these changes

View reviewed changes

Collaborator

NickGeneva left a comment

Approve to unblock

NickGeneva reviewed

View reviewed changes

earth2studio/models/px/dlesym.py Show resolved Hide resolved


          format fixes

8a45feb

Collaborator Author

pzharrington commented May 14, 2025

/blossom-ci

pzharrington merged commit 43a55a4 into NVIDIA:main

10 checks passed

NickGeneva mentioned this pull request

Derived variable in lexicon 'tau300-700' #292

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet