Skip to content

DLESyM notebook example #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 14, 2025
Merged

Conversation

pzharrington
Copy link
Collaborator

@pzharrington pzharrington commented May 9, 2025

Earth2Studio Pull Request

Description

Add a simple notebook example demonstrating DLESyM usage.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@pzharrington pzharrington self-assigned this May 9, 2025
@pzharrington pzharrington marked this pull request as draft May 9, 2025 17:30
@pzharrington pzharrington marked this pull request as ready for review May 13, 2025 23:03
@pzharrington
Copy link
Collaborator Author

/blossom-ci

@pzharrington pzharrington requested a review from NickGeneva May 13, 2025 23:05
@pzharrington
Copy link
Collaborator Author

/blossom-ci

@pzharrington
Copy link
Collaborator Author

/blossom-ci

@NickGeneva
Copy link
Collaborator

LGTM, going to pull and try running the example myself rq

@NickGeneva
Copy link
Collaborator

Random note in case this comes up again:

Had to install sudo apt-get install python3-dev to build earth2grid

fatal error: Python.h: No such
      file or directory
         12 | #include <Python.h>
            |          ^~~~~~~~~~
      compilation terminated.
      ninja: build stopped: subcommand failed.

@NickGeneva
Copy link
Collaborator

Example looks fantastic! added some minor changes needed.

Use make docs to test yourself to see if the rst looks good. This is great

Copy link
Collaborator

@NickGeneva NickGeneva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to unblock

@pzharrington
Copy link
Collaborator Author

/blossom-ci

@pzharrington pzharrington merged commit 43a55a4 into NVIDIA:main May 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants