Require SPDX copyright tags in source headers - #521
Conversation
ec4bccc to
18f27e2
Compare
|
/ready to test 18f27e2 |
|
/ok to test 18f27e2 |
Greptile SummaryThe PR strengthens source-header validation by requiring non-empty copyright and license tags and aligns contributor and agent documentation with the concise two-line SPDX form. The attempted string/docstring exclusion remains incomplete because bare
Confidence Score: 4/5The PR should not merge until the header matcher prevents bare The attempted fix still applies a bare- Files Needing Attention: .github/workflows/reuse-lint.yml Important Files Changed
Reviews (3): Last reviewed commit: "Anchor SPDX checks to comment headers" | Re-trigger Greptile |
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
66c4b3d to
cdc6b61
Compare
|
/ok to test cdc6b61 |
| copyright_pattern='^[[:space:]]*(#|//|/\*|\*)[[:space:]]*SPDX-FileCopyrightText:[[:space:]]*[^[:space:]]' | ||
| license_pattern='^[[:space:]]*(#|//|/\*|\*)[[:space:]]*SPDX-License-Identifier:[[:space:]]*[^[:space:]]' |
There was a problem hiding this comment.
When a Python, shell, or Dockerfile string or docstring contains * SPDX-FileCopyrightText: and * SPDX-License-Identifier: lines within its first 20 lines, the shared patterns treat them as source comments, causing a file without an actual SPDX comment header to pass the workflow.
Summary
Validation