Skip to content

[nvpassthrough] open files as WRONLY before writing #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdesiniotis merged 1 commit into from
Jun 5, 2026
Merged

[nvpassthrough] open files as WRONLY before writing #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions pkg/nvpassthrough/nvpassthrough.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,12 +276,12 @@ func (n *nvpassthrough) Unbind(address string) error {

func bind(address string, driver string) error {
driverOverridePath := filepath.Join(pciDevicesRoot, address, "driver_override")
if err := os.WriteFile(driverOverridePath, []byte(driver), 0644); err != nil {
if err := writeFile(driverOverridePath, driver); err != nil {
return fmt.Errorf("failed to set driver_override for %s: %w", address, err)
}

bindPath := filepath.Join(pciDriversRoot, driver, "bind")
if err := os.WriteFile(bindPath, []byte(address), 0644); err != nil {
if err := writeFile(bindPath, address); err != nil {
return fmt.Errorf("failed to bind %s to %s: %w", address, driver, err)
}

Expand All @@ -290,7 +290,7 @@ func bind(address string, driver string) error {

func unbind(address string) error {
driverOverridePath := filepath.Join(pciDevicesRoot, address, "driver_override")
if err := os.WriteFile(driverOverridePath, []byte("\n"), 0644); err != nil {
if err := writeFile(driverOverridePath, "\n"); err != nil {
return fmt.Errorf("failed to clear driver_override for %s: %w", address, err)
}

Expand All @@ -306,7 +306,7 @@ func unbind(address string) error {
driverName := filepath.Base(driverLink)

unbindPath := filepath.Join(driverPath, "unbind")
if err := os.WriteFile(unbindPath, []byte(address), 0644); err != nil {
if err := writeFile(unbindPath, address); err != nil {
return fmt.Errorf("failed to unbind %s from %s: %w", address, driverName, err)
}

Expand Down Expand Up @@ -365,3 +365,15 @@ func getDriver(devicePath string) (string, error) {
}
return "", err
}

func writeFile(path string, s string) error {
f, err := os.OpenFile(path, os.O_WRONLY|os.O_TRUNC, 0644)
if err != nil {
return fmt.Errorf("failed to open file for writing: %w", err)
}
defer f.Close()
if _, err = f.WriteString(s); err != nil {
return fmt.Errorf("failed writing to file: %w", err)
}
return nil
}