[release-25.10] [improvement] : fix minor issues with templates (#1863) #2061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Copyright 2024 NVIDIA CORPORATION | |
| # | |
| # Licensed under the Apache License, Version 2.0 (the "License"); | |
| # you may not use this file except in compliance with the License. | |
| # You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| name: CI | |
| on: | |
| push: | |
| branches: | |
| - "pull-request/[0-9]+" | |
| - main | |
| - release-* | |
| jobs: | |
| ### Configuration checks ### | |
| helm-lint: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v5 | |
| - name: Install Helm | |
| uses: azure/[email protected] | |
| id: install | |
| - run: helm lint deployments/gpu-operator/ | |
| validate-csv: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v5 | |
| - name: Get Golang version | |
| id: vars | |
| run: | | |
| GOLANG_VERSION=$( grep "GOLANG_VERSION ?=" versions.mk ) | |
| echo "GOLANG_VERSION=${GOLANG_VERSION##GOLANG_VERSION ?= }" >> $GITHUB_ENV | |
| - name: Install Go | |
| uses: actions/setup-go@v6 | |
| with: | |
| go-version: ${{ env.GOLANG_VERSION }} | |
| - run: make validate-csv | |
| validate-helm-values: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v5 | |
| - name: Get Golang version | |
| id: vars | |
| run: | | |
| GOLANG_VERSION=$( grep "GOLANG_VERSION ?=" versions.mk ) | |
| echo "GOLANG_VERSION=${GOLANG_VERSION##GOLANG_VERSION ?= }" >> $GITHUB_ENV | |
| - name: Install Go | |
| uses: actions/setup-go@v6 | |
| with: | |
| go-version: ${{ env.GOLANG_VERSION }} | |
| - run: make validate-helm-values | |
| ### Golang checks and build ### | |
| go-check: | |
| needs: [helm-lint, validate-csv, validate-helm-values] | |
| runs-on: linux-amd64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Checkout code | |
| - name: Get Golang version | |
| id: vars | |
| run: | | |
| GOLANG_VERSION=$( grep "GOLANG_VERSION ?=" versions.mk ) | |
| GOLANGCI_LINT_VERSION=$( grep "GOLANGCI_LINT_VERSION ?=" versions.mk ) | |
| echo "GOLANG_VERSION=${GOLANG_VERSION##GOLANG_VERSION ?= }" >> $GITHUB_ENV | |
| echo "GOLANGCI_LINT_VERSION=${GOLANGCI_LINT_VERSION##GOLANGCI_LINT_VERSION ?= }" >> $GITHUB_ENV | |
| - name: Install Go | |
| uses: actions/setup-go@v6 | |
| with: | |
| go-version: ${{ env.GOLANG_VERSION }} | |
| - name: Lint | |
| uses: golangci/golangci-lint-action@v8 | |
| with: | |
| version: ${{ env.GOLANGCI_LINT_VERSION }} | |
| args: -v --timeout 5m | |
| skip-cache: true | |
| - name: Setup Go Proxy | |
| id: setup-go-proxy | |
| uses: nv-gha-runners/setup-artifactory-go-proxy@main | |
| - env: | |
| GOPROXY: ${{ steps.setup-go-proxy.outputs.goproxy-url }} | |
| run: | | |
| make check | |
| go-test: | |
| needs: [helm-lint, validate-csv, validate-helm-values] | |
| name: unit tests | |
| runs-on: linux-amd64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v5 | |
| - name: Get Golang version | |
| id: vars | |
| run: | | |
| GOLANG_VERSION=$( grep "GOLANG_VERSION ?=" versions.mk ) | |
| echo "GOLANG_VERSION=${GOLANG_VERSION##GOLANG_VERSION ?= }" >> $GITHUB_ENV | |
| - name: Install Go | |
| uses: actions/setup-go@v6 | |
| with: | |
| go-version: ${{ env.GOLANG_VERSION }} | |
| - name: Setup Go Proxy | |
| id: setup-go-proxy | |
| uses: nv-gha-runners/setup-artifactory-go-proxy@main | |
| - env: | |
| GOPROXY: ${{ steps.setup-go-proxy.outputs.goproxy-url }} | |
| run: | | |
| make coverage | |
| go-build: | |
| needs: [helm-lint, validate-csv, validate-helm-values] | |
| runs-on: linux-amd64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Checkout code | |
| - run: make docker-build | |
| coverage: | |
| needs: [go-test] | |
| runs-on: linux-amd64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v5 | |
| - name: Get Golang version | |
| id: vars | |
| run: | | |
| GOLANG_VERSION=$( grep "GOLANG_VERSION ?=" versions.mk ) | |
| echo "GOLANG_VERSION=${GOLANG_VERSION##GOLANG_VERSION ?= }" >> $GITHUB_ENV | |
| - name: Set up Go | |
| uses: actions/setup-go@v6 | |
| with: | |
| go-version: ${{ env.GOLANG_VERSION }} | |
| - name: Setup Go Proxy | |
| id: setup-go-proxy | |
| uses: nv-gha-runners/setup-artifactory-go-proxy@main | |
| - name: Generate coverage report | |
| env: | |
| GOPROXY: ${{ steps.setup-go-proxy.outputs.goproxy-url }} | |
| run: | | |
| make cov-report | |
| - name: Upload to Coveralls | |
| uses: coverallsapp/github-action@v2 | |
| with: | |
| github-token: ${{ secrets.GITHUB_TOKEN }} | |
| path-to-lcov: lcov.info | |
| ### Image builds ### | |
| build-gpu-operator-arm64: | |
| needs: [go-check, go-test, go-build] | |
| runs-on: linux-arm64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| packages: write | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Check out code | |
| - name: Calculate build vars | |
| id: vars | |
| run: | | |
| echo "COMMIT_SHORT_SHA=${GITHUB_SHA:0:8}" >> $GITHUB_ENV | |
| echo "LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}')" >> $GITHUB_ENV | |
| REPO_FULL_NAME="${{ github.event.pull_request.head.repo.full_name }}" | |
| echo "${REPO_FULL_NAME}" | |
| echo "LABEL_IMAGE_SOURCE=https://github.com/${REPO_FULL_NAME}" >> $GITHUB_ENV | |
| GENERATE_ARTIFACTS="false" | |
| if [[ "${{ github.actor }}" == "dependabot[bot]" ]]; then | |
| GENERATE_ARTIFACTS="false" | |
| elif [[ "${{ github.event_name }}" == "pull_request" && "${{ github.event.pull_request.head.repo.full_name }}" == "${{ github.repository }}" ]]; then | |
| GENERATE_ARTIFACTS="true" | |
| elif [[ "${{ github.event_name }}" == "push" ]]; then | |
| GENERATE_ARTIFACTS="true" | |
| fi | |
| echo "PUSH_ON_BUILD=${GENERATE_ARTIFACTS}" >> $GITHUB_ENV | |
| echo "DOCKER_BUILD_PLATFORM_OPTIONS=--platform=linux/arm64" >> $GITHUB_ENV | |
| - name: Set up Docker Buildx | |
| uses: docker/setup-buildx-action@v3 | |
| - name: Login to GitHub Container Registry | |
| uses: docker/login-action@v3 | |
| with: | |
| registry: ghcr.io | |
| username: ${{ github.actor }} | |
| password: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Setup Go Proxy | |
| id: setup-go-proxy | |
| uses: nv-gha-runners/setup-artifactory-go-proxy@main | |
| - name: Build image | |
| env: | |
| IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/gpu-operator | |
| VERSION: ${COMMIT_SHORT_SHA}-arm64 | |
| GOPROXY: ${{ steps.setup-go-proxy.outputs.goproxy-url }} | |
| run: | | |
| echo "${VERSION}" | |
| make build-image | |
| build-gpu-operator-amd64: | |
| needs: [go-check, go-test, go-build] | |
| runs-on: linux-amd64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| packages: write | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Check out code | |
| - name: Calculate build vars | |
| id: vars | |
| run: | | |
| echo "COMMIT_SHORT_SHA=${GITHUB_SHA:0:8}" >> $GITHUB_ENV | |
| echo "LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}')" >> $GITHUB_ENV | |
| REPO_FULL_NAME="${{ github.event.pull_request.head.repo.full_name }}" | |
| echo "${REPO_FULL_NAME}" | |
| echo "LABEL_IMAGE_SOURCE=https://github.com/${REPO_FULL_NAME}" >> $GITHUB_ENV | |
| GENERATE_ARTIFACTS="false" | |
| if [[ "${{ github.actor }}" == "dependabot[bot]" ]]; then | |
| GENERATE_ARTIFACTS="false" | |
| elif [[ "${{ github.event_name }}" == "pull_request" && "${{ github.event.pull_request.head.repo.full_name }}" == "${{ github.repository }}" ]]; then | |
| GENERATE_ARTIFACTS="true" | |
| elif [[ "${{ github.event_name }}" == "push" ]]; then | |
| GENERATE_ARTIFACTS="true" | |
| fi | |
| echo "PUSH_ON_BUILD=${GENERATE_ARTIFACTS}" >> $GITHUB_ENV | |
| echo "DOCKER_BUILD_PLATFORM_OPTIONS=--platform=linux/amd64" >> $GITHUB_ENV | |
| - name: Set up Docker Buildx | |
| uses: docker/setup-buildx-action@v3 | |
| - name: Login to GitHub Container Registry | |
| uses: docker/login-action@v3 | |
| with: | |
| registry: ghcr.io | |
| username: ${{ github.actor }} | |
| password: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Setup Go Proxy | |
| id: setup-go-proxy | |
| uses: nv-gha-runners/setup-artifactory-go-proxy@main | |
| - name: Build image | |
| env: | |
| IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/gpu-operator | |
| VERSION: ${COMMIT_SHORT_SHA}-amd64 | |
| GOPROXY: ${{ steps.setup-go-proxy.outputs.goproxy-url }} | |
| run: | | |
| echo "${VERSION}" | |
| make build-image | |
| build-multi-arch-images: | |
| needs: [build-gpu-operator-arm64, build-gpu-operator-amd64] | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Check out code | |
| - name: Calculate build vars | |
| id: vars | |
| run: | | |
| echo "COMMIT_SHORT_SHA=${GITHUB_SHA:0:8}" >> $GITHUB_ENV | |
| echo "LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}')" >> $GITHUB_ENV | |
| - name: Login to GitHub Container Registry | |
| uses: docker/login-action@v3 | |
| with: | |
| registry: ghcr.io | |
| username: ${{ github.actor }} | |
| password: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Build Manifest | |
| env: | |
| OPERATOR_IMAGE_ARM: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/gpu-operator:${{ env.COMMIT_SHORT_SHA }}-arm64 | |
| OPERATOR_IMAGE_AMD: ghcr.io/${{ env.LOWERCASE_REPO_OWNER}}/gpu-operator:${{ env.COMMIT_SHORT_SHA }}-amd64 | |
| OPERATOR_MULTIARCH_IMAGE: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/gpu-operator:${{ env.COMMIT_SHORT_SHA }} | |
| run: | | |
| docker manifest create \ | |
| ${OPERATOR_MULTIARCH_IMAGE} \ | |
| ${OPERATOR_IMAGE_AMD} \ | |
| ${OPERATOR_IMAGE_ARM} | |
| docker manifest push ${OPERATOR_MULTIARCH_IMAGE} | |
| ### e2e tests ### | |
| e2e-tests-containerd: | |
| needs: [build-multi-arch-images] | |
| runs-on: linux-amd64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Check out code | |
| - name: Set up Holodeck | |
| uses: NVIDIA/[email protected] | |
| with: | |
| aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }} | |
| aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | |
| aws_ssh_key: ${{ secrets.AWS_SSH_KEY }} | |
| holodeck_config: "tests/holodeck.yaml" | |
| - name: Get public dns name | |
| id: get_public_dns_name | |
| uses: mikefarah/yq@master | |
| with: | |
| cmd: yq '.status.properties[] | select(.name == "public-dns-name") | .value' /github/workspace/.cache/holodeck.yaml | |
| - name: Calculate test vars | |
| id: vars | |
| run: | | |
| COMMIT_SHORT_SHA=${GITHUB_SHA:0:8} | |
| echo "COMMIT_SHORT_SHA=${GITHUB_SHA:0:8}" >> $GITHUB_ENV | |
| LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}') | |
| echo "LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}')" >> $GITHUB_ENV | |
| echo "OPERATOR_VERSION=${COMMIT_SHORT_SHA}" >> $GITHUB_ENV | |
| echo "OPERATOR_IMAGE=ghcr.io/${LOWERCASE_REPO_OWNER}/gpu-operator" >> $GITHUB_ENV | |
| echo "instance_hostname=ubuntu@${{ steps.get_public_dns_name.outputs.result }}" >> $GITHUB_ENV | |
| echo "private_key=${{ github.workspace }}/key.pem" >> $GITHUB_ENV | |
| - name: Run e2e tests | |
| env: | |
| GPU_PRODUCT_NAME: "Tesla-T4" | |
| SKIP_LAUNCH: "true" | |
| CONTAINER_RUNTIME: "containerd" | |
| TEST_CASE: "./tests/cases/defaults.sh" | |
| run: | | |
| echo "${{ secrets.AWS_SSH_KEY }}" > ${private_key} && chmod 400 ${private_key} | |
| ./tests/ci-run-e2e.sh ${OPERATOR_IMAGE} ${OPERATOR_VERSION} ${GPU_PRODUCT_NAME} ${TEST_CASE} || rc=$? | |
| ./tests/scripts/pull.sh /tmp/logs logs | |
| exit $rc | |
| - name: Archive test logs | |
| if: ${{ failure() }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: containerd-e2e-test-logs | |
| path: ./logs/ | |
| retention-days: 15 | |
| e2e-tests-nvidiadriver: | |
| needs: [build-multi-arch-images] | |
| runs-on: linux-amd64-cpu4 | |
| permissions: | |
| contents: read | |
| id-token: write | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Check out code | |
| - name: Set up Holodeck | |
| uses: NVIDIA/[email protected] | |
| with: | |
| aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }} | |
| aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | |
| aws_ssh_key: ${{ secrets.AWS_SSH_KEY }} | |
| holodeck_config: "tests/holodeck.yaml" | |
| - name: Get public dns name | |
| id: get_public_dns_name | |
| uses: mikefarah/yq@master | |
| with: | |
| cmd: yq '.status.properties[] | select(.name == "public-dns-name") | .value' /github/workspace/.cache/holodeck.yaml | |
| - name: Calculate test vars | |
| id: vars | |
| run: | | |
| COMMIT_SHORT_SHA=${GITHUB_SHA:0:8} | |
| echo "COMMIT_SHORT_SHA=${GITHUB_SHA:0:8}" >> $GITHUB_ENV | |
| LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}') | |
| echo "LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}')" >> $GITHUB_ENV | |
| echo "OPERATOR_VERSION=${COMMIT_SHORT_SHA}" >> $GITHUB_ENV | |
| echo "OPERATOR_IMAGE=ghcr.io/${LOWERCASE_REPO_OWNER}/gpu-operator" >> $GITHUB_ENV | |
| echo "instance_hostname=ubuntu@${{ steps.get_public_dns_name.outputs.result }}" >> $GITHUB_ENV | |
| echo "private_key=${{ github.workspace }}/key.pem" >> $GITHUB_ENV | |
| - name: Run e2e tests | |
| env: | |
| GPU_PRODUCT_NAME: "Tesla-T4" | |
| SKIP_LAUNCH: "true" | |
| CONTAINER_RUNTIME: "containerd" | |
| TEST_CASE: "./tests/cases/nvidia-driver.sh" | |
| run: | | |
| echo "${{ secrets.AWS_SSH_KEY }}" > ${private_key} && chmod 400 ${private_key} | |
| ./tests/ci-run-e2e.sh ${OPERATOR_IMAGE} ${OPERATOR_VERSION} ${GPU_PRODUCT_NAME} ${TEST_CASE} || rc=$? | |
| ./tests/scripts/pull.sh /tmp/logs logs | |
| exit $rc | |
| - name: Archive test logs | |
| if: ${{ failure() }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: nvidiadriver-e2e-test-logs | |
| path: ./logs/ | |
| retention-days: 15 | |
| release-latest-gpu-operator-image: | |
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} # Runs only if the event is a push to the main branch | |
| needs: [e2e-tests-containerd, e2e-tests-nvidiadriver] | |
| runs-on: linux-amd64-cpu4 | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Check out code | |
| - name: set-up regctl | |
| run: | | |
| export REGCTL_VERSION=v0.9.2 | |
| mkdir -p bin | |
| curl -sSLo bin/regctl https://github.com/regclient/regclient/releases/download/${REGCTL_VERSION}/regctl-linux-amd64 | |
| chmod a+x bin/regctl | |
| echo "$(pwd)/bin" >> $GITHUB_PATH | |
| - name: Set environment variables | |
| id: vars | |
| run: | | |
| COMMIT_SHORT_SHA=${GITHUB_SHA:0:8} | |
| LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}') | |
| echo "OPERATOR_VERSION=${COMMIT_SHORT_SHA}" >> $GITHUB_ENV | |
| echo "OPERATOR_IMAGE=ghcr.io/${LOWERCASE_REPO_OWNER}/gpu-operator" >> $GITHUB_ENV | |
| - name: Retag gpu-operator | |
| run: | | |
| regctl registry login ghcr.io -u $GITHUB_ACTOR -p ${{ secrets.GITHUB_TOKEN }} | |
| regctl image copy ${OPERATOR_IMAGE}:${OPERATOR_VERSION} ${OPERATOR_IMAGE}:main-latest | |
| push-gpu-operator-bundle-image: | |
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} # Runs only if the event is a push to the main branch | |
| needs: [release-latest-gpu-operator-image] | |
| runs-on: linux-amd64-cpu4 | |
| steps: | |
| - uses: actions/checkout@v5 | |
| name: Check out code | |
| - name: Login to GitHub Container Registry | |
| uses: docker/login-action@v3 | |
| with: | |
| registry: ghcr.io | |
| username: ${{ github.actor }} | |
| password: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Build bundle-image | |
| env: | |
| BUNDLE_IMAGE: "ghcr.io/nvidia/gpu-operator/gpu-operator-bundle:${{ github.ref_name }}-latest" | |
| VERSION: "" | |
| DEFAULT_CHANNEL: "stable" | |
| CHANNELS: "stable" | |
| run: | | |
| make push-bundle-image |