fix: turn on FNN in struct used during site creation

[bcavnvidia]

REST DB migrations were created to default new sites to FNN VPC creation, but a struct being used during site creation is overriding that.

This PR fixes that so new sites default to FNN.

Related issues

#2522

Type of Change

• Add - New feature or capability
• Change - Changes in existing functionality
• Fix - Bug fixes
• Remove - Removed features or deprecated functionality
• Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

• This PR contains breaking changes

Testing

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed
• No testing required (docs, internal refactor, etc.)

Additional Notes

[coderabbitai]

Walkthrough

CreateSiteHandler.Handle now initializes new SiteConfig records with both NativeNetworking: true and NetworkSecurityGroup: true. The corresponding test asserts that the API response carries non-nil Capabilities with both flags enabled, and re-fetches the site from the database to confirm the persisted Config reflects the same values.

Changes

Default NativeNetworking on Site Creation

Layer / File(s)	Summary
NativeNetworking default and verification rest-api/api/pkg/api/handler/site.go, rest-api/api/pkg/api/handler/site_test.go	SiteConfig initialization expanded with NativeNetworking: true; test success path extended to assert Capabilities.NativeNetworking and Capabilities.NetworkSecurityGroup in the API response, plus a DB reload check confirming the persisted Config values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the primary change: enabling FNN (NativeNetworking) in the struct used during site creation, which aligns with the code modifications.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description accurately describes the changeset: it addresses a struct override issue preventing FNN VPC defaults from being applied during site creation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔍 Container Scan Summary

Service	Total	Critical	High	Medium	Low	Other
nico-flow	126	14	55	44	5	8
nico-nsm	133	11	45	66	11	0
nico-psm	128	14	57	44	5	8
nico-rest-api	192	17	89	70	8	8
nico-rest-cert-manager	105	6	52	35	4	8
nico-rest-db	126	14	55	44	5	8
nico-rest-site-agent	125	14	55	44	4	8
nico-rest-site-manager	112	7	53	40	4	8
nico-rest-workflow	128	14	57	44	5	8
TOTAL	1175	111	518	431	51	64

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

[github-actions]

🔐 TruffleHog Secret Scan

✅ No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

_{🕐 Last updated: 2026-06-16 20:04:12 UTC | Commit: d29aeb1}