Expose device UUIDs to node label#1116
Conversation
xiongzubiao
force-pushed
the
uuid
branch
2 times, most recently
from
eb8fdec to
2ad1041
Compare
|
@xiongzubiao could you please provide information on how these labels will be used? |
@elezar, we want to provide some sort of visualization to user. User can click each GPU to check its properties, status, and metrics. The device UUID is the natural choice for indexing. There are other ways to get UUID, but it is most straightforward to get it from node labels, because it is a part of node properties. There is another use case mentioned in #1015: scheduling pod to a specific GPU using node label matching. |
Signed-off-by: Zubiao Xiong <zubiao.xiong@memverge.com>
|
would like to have such a label in a scope of our project too. Where we need to see the GPU UUISs linked to node. So we can use that info in our workflows. |
| func NewDeviceMock(migEnabled bool) *DeviceMock { | ||
| d := DeviceMock{resource.DeviceMock{ | ||
| GetNameFunc: func() (string, error) { return "MOCKMODEL", nil }, | ||
| GetUUIDFunc: func() (string, error) { return "MOCKUUID", nil }, |
There was a problem hiding this comment.
We need a negative test case too maybe. e.g. when we couldn't get the uuid.
|
While the PR is appropriate and the implementation is good, we are not sure if we want to add extra labels unless necessary. Closing the PR. Please re-open if anyone disagrees. |
5 participants
Closes #1015