chore: Update golang version to 1.24 #1233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjiang1989
changed the title
tariq1890
reviewed
Apr 21, 2025
tariq1890
reviewed
Apr 21, 2025
| module github.com/NVIDIA/k8s-device-plugin/deployments/devel | ||
|
|
||
| go 1.23 | ||
| go 1.24 |
There was a problem hiding this comment.
Is this needed? Unless the minimum required go version to build k8s-device-plugin is truly 1.24, we shouldn't be changing this
There was a problem hiding this comment.
Not required.
By upgrading to the latest version of golang, we can ensure that the dependabot gomod base library can be upgraded to the latest version(like: k8s/* v0.33)
tariq1890
reviewed
Apr 21, 2025
| module github.com/NVIDIA/k8s-device-plugin | ||
|
|
||
| go 1.23.0 | ||
| go 1.24 |
dongjiang1989
force-pushed
the
update-golang-version
branch
2 times, most recently
from
b0edbc3 to
434931e
Compare
Signed-off-by: dongjiang <[email protected]>
Co-authored-by: Tariq <[email protected]> Signed-off-by: dongjiang <[email protected]>
dongjiang1989
force-pushed
the
update-golang-version
branch
from
434931e to
39eb744
Compare
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. |
github-actions
bot
added
the
lifecycle/stale
|
Please note that Dependabot handles this automatically. See #1319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.