Allow unsetting runtimeClassName#1625
Closed
sklirg wants to merge 1 commit into
Closed
Conversation
Default value to nil in case it is unset. If the value previously has been set, but is now unset, the conditional branch would remove the field from the generated manifest, resulting in a manifest merge to retain the field as it was not specified to be removed/nulled. Signed-off-by: Håkon Solbjørg <hakon@solbj.org>
Contributor
|
Not sure if this is the right solution. Closing this PR. Please re-open if anyone thinks it is still the right path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default value to nil in case it is unset.
If the value previously has been set, but is now unset, the conditional branch would remove the field from the generated manifest, resulting in a manifest merge to retain the field as it was not specified to be removed/nulled.