Skip to content

Conversation

@ArangoGutierrez
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses the renaming of variables to align with the daemonSet context in the computeDomain controller.

  • Updated variable names from "deploymentYaml" to "daemonSetYaml" for improved clarity.
  • Refactored the conversion from a deployment object to a daemonSet object, and updated the creation call accordingly.
Comments suppressed due to low confidence (1)

cmd/compute-domain-controller/daemonset.go:192

  • The renaming from 'deploymentYaml' to 'daemonSetYaml' improves clarity. Ensure that any associated comments or documentation are updated consistently to reflect this change.
var daemonSetYaml bytes.Buffer

Copy link
Collaborator

@jgehrcke jgehrcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(for the record, this was a follow-up from #381)

@jgehrcke
Copy link
Collaborator

jgehrcke commented Jun 4, 2025

Let's get this in. Thanks again.

@jgehrcke jgehrcke merged commit f2cef6f into NVIDIA:main Jun 4, 2025
13 checks passed
@klueska klueska added this to the v25.3.0 milestone Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants