-
Notifications
You must be signed in to change notification settings - Fork 94
bats-tests: add TEST_CHART_LOCAL, add tests, adjust readme #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
152e93a to
2c8eafa
Compare
| # Consumed in upgrade test via kubectl apply -f <URL> | ||
| # (can be a branch, tag, or commit). TODO: parse default | ||
| # from `TEST_CHART_VERSION`. | ||
| TEST_CRD_UPGRADE_TARGET_GIT_REF ?= "main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: override this, too, for local dev (consume from local checkout).
will do in a follow-up.
|
It feels a bit awkward to have to set a separate variable of TEST_CHART_LOCAL to enable local development. I would actually expect the default to be local development, i.e. When you then optionally override if you want to test something externally. |
|
Thanks for having had a quick look!
Right... because it is awkward :).
I agree that we want to have a proper 'local first' procedure. Screenshot from my planning doc: That is: tested system based on local state, including container image, CRD, Helm chart (and whatever I forgot to enumerate here). Today, this doesn't work auto-magically because images need to be built and get to the nodes. I don't want I explicitly want to iterate rather ruthlessly on the configuration interface for now. It's important to get the feedback and have the discussion. For today, I'd like to move forward with this patch because I'm stacking PRs (#598) and I'd like to minimize overhead. |
|
Will move forward with this. The test and README adjustments here are useful, and used in #598, #610. Also discussed out-of-band: I will pay attention to not breaking established workflows, and I appreciate that we bear with me for the moment. It's important for me to move fast and keep my momentum up as I try to converge sub efforts quickly here. Again, the ultimate goal is to get us to start iterating against CI (before that, everything is rather premature, especially interface considerations and technical priorities will become clearest in view of CI). |

For #613.
Introduces
TEST_CHART_LOCAL.You may want to review the rendered readme update.
Output:
Still works: