CD health check: adjust naming and log messages for clarity #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
jgehrcke
commented
Oct 8, 2025
| } | ||
|
|
||
| func startHealthcheck(ctx context.Context, config *Config) (*healthcheck, error) { | ||
| func setupHealthcheckPrimitives(ctx context.Context, config *Config) (*healthcheck, error) { |
There was a problem hiding this comment.
previous discussion: #633 (comment)
jgehrcke
commented
Oct 8, 2025
| } | ||
|
|
||
| // Check implements [grpc_health_v1.HealthServer]. | ||
| // Check implements [grpc_health_v1.HealthServer.Check]. |
There was a problem hiding this comment.
previous discussion: #633 (comment)
klueska
added
the
debuggability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out of #633.