Skip to content

Conversation

@nmn3m
Copy link

@nmn3m nmn3m commented Oct 9, 2025

Capitalize All Log Messages for Consistency

Start all klog log messages with an uppercase character across the codebase.
This ensures consistent log formatting and improves readability.

Fixes: #645

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nmn3m nmn3m force-pushed the fix/capitalize-log-messages branch 2 times, most recently from f1c473e to 9c3e475 Compare October 9, 2025 15:41
@nmn3m
Copy link
Author

nmn3m commented Oct 9, 2025

@jgehrcke can you please take a look ?.

@jgehrcke
Copy link
Collaborator

jgehrcke commented Oct 9, 2025

Thanks @nmn3m with lower-case n. That's an upper-class effort! 🌞 Sorry for the jokes.

I'd appreciate if we can let this sit for a bit. There are a number of PRs in flight that will have merge conflicts if we were to land this one.

@nmn3m
Copy link
Author

nmn3m commented Oct 9, 2025

Thanks @jgehrcke 😊
I’ll be happy to help anytime — I’m particularly interested in DRA, both from the Kubernetes and NVIDIA sides.
Please feel free to ping me for any related issues or discussions.

By the way, is there a way for me to check or identify which PRs might cause merge conflicts with this one?
Also, if there are any related issues or PRs I can help with, I’d be happy to contribute!

@klueska klueska added the debuggability issue/pr related to the ability to debug the system label Oct 10, 2025
@klueska klueska added this to the unscheduled milestone Oct 10, 2025
@jgehrcke jgehrcke added maintenance/chores issue/pr for maintenance, release work, code cleanup, chores and removed debuggability issue/pr related to the ability to debug the system labels Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance/chores issue/pr for maintenance, release work, code cleanup, chores

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants