Skip to content

Conversation

@cdesiniotis
Copy link
Collaborator

@cdesiniotis cdesiniotis commented Dec 12, 2025

// vfio_pci module is not loaded initially
$ lsmod | grep vfio_pci
vfio_pci_core          69632  0
vfio_virqfd            16384  1 vfio_pci_core
vfio                   45056  2 vfio_pci_core,vfio_iommu_type1
irqbypass              16384  2 vfio_pci_core,kvm

$ sudo ./vfio-manage bind --all
INFO[2025-12-20T00:00:12Z] Binding device 0000:3b:00.0
INFO[2025-12-20T00:00:12Z] Binding device 0000:3b:00.0 to driver: vfio-pci
INFO[2025-12-20T00:00:12Z] Binding device 0000:d8:00.0
INFO[2025-12-20T00:00:12Z] Binding device 0000:d8:00.0 to driver: vfio-pci

$ lsmod | grep vfio_pci
vfio_pci               16384  0
vfio_pci_core          69632  1 vfio_pci
vfio_virqfd            16384  1 vfio_pci_core
vfio                   45056  2 vfio_pci_core,vfio_iommu_type1
irqbypass              16384  2 vfio_pci_core,kvm

$ lspci -nnk -d 10de:
3b:00.0 3D controller [0302]: NVIDIA Corporation GA102GL [A40] [10de:2235] (rev a1)
	Subsystem: NVIDIA Corporation Device [10de:145a]
	Kernel driver in use: vfio-pci
	Kernel modules: nouveau
d8:00.0 3D controller [0302]: NVIDIA Corporation GA102GL [A40] [10de:2235] (rev a1)
	Subsystem: NVIDIA Corporation Device [10de:145a]
	Kernel driver in use: vfio-pci
	Kernel modules: nouveau

@coveralls
Copy link

coveralls commented Dec 12, 2025

Pull Request Test Coverage Report for Build 20732432159

Details

  • 0 of 43 (0.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 6.393%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/linuxutils/kmod.go 0 7 0.0%
cmd/vfio-manage/unbind.go 0 10 0.0%
internal/nvpci/nvpci.go 0 11 0.0%
cmd/vfio-manage/bind.go 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/vfio-manage/bind.go 1 0.0%
cmd/vfio-manage/unbind.go 1 0.0%
internal/linuxutils/kmod.go 1 0.0%
Totals Coverage Status
Change from base Build 20252701997: -0.08%
Covered Lines: 84
Relevant Lines: 1314

💛 - Coveralls

@cdesiniotis cdesiniotis force-pushed the load-modules-in-vfio-manage branch 3 times, most recently from a29b0b8 to d9cc47b Compare December 12, 2025 22:54
@cdesiniotis cdesiniotis force-pushed the load-modules-in-vfio-manage branch from d9cc47b to 4089642 Compare December 20, 2025 00:09
@cdesiniotis cdesiniotis marked this pull request as ready for review December 20, 2025 00:24
tariq1890
tariq1890 previously approved these changes Dec 20, 2025
@tariq1890 tariq1890 dismissed their stale review December 20, 2025 01:28

Approved by mistake

@cdesiniotis cdesiniotis force-pushed the load-modules-in-vfio-manage branch from 4089642 to f830192 Compare December 22, 2025 22:31
@cdesiniotis cdesiniotis force-pushed the load-modules-in-vfio-manage branch from f830192 to 80f1e59 Compare January 5, 2026 22:37
@cdesiniotis cdesiniotis force-pushed the load-modules-in-vfio-manage branch from 80f1e59 to 7515925 Compare January 5, 2026 23:29
@cdesiniotis
Copy link
Collaborator Author

I forgot to remove an unused constant in internal/linuxutils/kmod.go after removing some code. I have removed this constant now. Will merge after the CI passes.

@cdesiniotis cdesiniotis merged commit 69eec27 into main Jan 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants