remove additional-drivers-flags file on driver uninstall #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
7 tasks
Author
|
No longer required in favor of 1c24003e76ff925a31b9474c33326627348327bb. That logic now changes things and this step of removing additional-drivers-flags file is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: NVIDIA/gpu-operator#2014
This PR adds logic to remove the newly added
.additional-drivers-flagsfile during driver uninstall. This is required because we don't want toolkit's validation container to use a stale file from previous install. Its possible some additional drivers gets disabled and we want to make sure toolkit's validation container reads the file which is generated by nvidia-driver and not something from an old install which might get updated later on by nvidia-driver.