Skip to content

cherry-pick: Handle updated model manifest path with latest NIMs (#262) #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivamerla merged 1 commit into from
Dec 19, 2024
Merged

cherry-pick: Handle updated model manifest path with latest NIMs (#262) #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion internal/controller/nimcache_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,21 @@ func getManifestConfigName(nimCache *appsv1alpha1.NIMCache) string {
return fmt.Sprintf("%s-manifest", nimCache.GetName())
}

func getCommand() []string {
return []string{
"sh",
"-c",
strings.Join([]string{
"if [ -f /opt/nim/etc/default/model_manifest.yaml ]; then",
"cat /opt/nim/etc/default/model_manifest.yaml;",
"else",
"cat /etc/nim/config/model_manifest.yaml;",
"fi;",
"sleep infinity",
}, " "),
}
}

// constructPodSpec constructs a Pod specification
func constructPodSpec(nimCache *appsv1alpha1.NIMCache, platformType k8sutil.OrchestratorType) *corev1.Pod {
labels := map[string]string{
Expand Down Expand Up @@ -938,7 +953,7 @@ func constructPodSpec(nimCache *appsv1alpha1.NIMCache, platformType k8sutil.Orch
{
Name: NIMCacheContainerName,
Image: nimCache.Spec.Source.NGC.ModelPuller,
Command: []string{"sh", "-c", "cat /etc/nim/config/model_manifest.yaml; sleep infinity"},
Command: getCommand(),
SecurityContext: &corev1.SecurityContext{
AllowPrivilegeEscalation: ptr.To[bool](false),
Capabilities: &corev1.Capabilities{
Expand Down
Loading