Skip to content

Conversation

@visheshtanksale
Copy link
Collaborator

No description provided.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@visheshtanksale visheshtanksale force-pushed the nemo-eval branch 2 times, most recently from 6dea733 to 06e60e8 Compare January 8, 2025 18:55
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Lets address the API changes and we can get this merged.

shivamerla
shivamerla previously approved these changes Jan 15, 2025
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@visheshtanksale visheshtanksale enabled auto-merge (squash) January 16, 2025 00:06
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
@visheshtanksale visheshtanksale merged commit 94d323f into NVIDIA:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants