Modify NeMoDataStore #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

shivamerla merged 4 commits into NVIDIA:main from shengnuo:dsv2

Jan 27, 2025

Collaborator

shengnuo commented Jan 16, 2025 •

edited

Loading

New API for supporting DataStore V2

Sample CR can be found at config/samples/apps_v1alpha1_nimdatastorev2.yaml

pre-requisite components:

Minio
Postgres

Secrets as specified in .spec.dataStoreParams that need to be created before deploying DataStore microservice

datastoreConfigSecret
datastoreInitSecret
datastoreInlineConfigSecret
extDBSetting.databaseSecret
giteaAdminSecret
lfsJwtSecret
objectStoreSetting.objectStoreSecret

shengnuo requested review from ArangoGutierrez, shivamerla and visheshtanksale as code owners

January 16, 2025 22:00

copy-pr-bot bot commented Jan 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

shengnuo changed the title ~~Support DataStore V2~~ Draft: Support DataStore V2

shengnuo force-pushed the dsv2 branch from fe0c2cd to 3289d83 Compare

January 16, 2025 22:11

slu2011 previously approved these changes

View reviewed changes

Contributor

slu2011 left a comment

LGTM

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastorev2_types.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastorev2_types.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

internal/controller/nemo_datastorev2_controller.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

internal/controller/nemo_datastorev2_controller.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastorev2_types.go Outdated Show resolved Hide resolved

shengnuo dismissed slu2011’s stale review via

55ee5ce

January 18, 2025 23:00

shengnuo force-pushed the dsv2 branch 4 times, most recently from 2635757 to 735cdd7 Compare

January 18, 2025 23:42

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

bundle/manifests/apps.nvidia.com_nemodatastores.yaml Outdated Show resolved Hide resolved

shivamerla reviewed

View reviewed changes

internal/controller/nemo_datastore_controller.go Outdated Show resolved Hide resolved

shengnuo force-pushed the dsv2 branch 4 times, most recently from 37ed08c to adfeb38 Compare

January 22, 2025 23:09

shengnuo changed the title ~~Draft: Support DataStore V2~~ Draft: Modify NeMoDataStore

shengnuo force-pushed the dsv2 branch from adfeb38 to 7ae1f96 Compare

January 23, 2025 21:07

shengnuo changed the title ~~Draft: Modify NeMoDataStore~~ Modify NeMoDataStore

varunrsekar reviewed

View reviewed changes

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

shengnuo force-pushed the dsv2 branch from 7ae1f96 to 32f0086 Compare

January 24, 2025 16:07

slu2011 and others added 3 commits

January 24, 2025 11:13


          chore: temp work to support datastore v2

e380515

Signed-off-by: Sheng Lin <shelin@nvidia.com>


          Support DataStore V2

d4009d8

Signed-off-by: Sheng Lin <shelin@nvidia.com>


          Deprecate DataStore v1

32ff019

Signed-off-by: Sheng Lin <shelin@nvidia.com>

shengnuo force-pushed the dsv2 branch from 32f0086 to 29b27f6 Compare

January 24, 2025 17:47

visheshtanksale reviewed

View reviewed changes

Collaborator

visheshtanksale left a comment

Some minor comments.

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

api/apps/v1alpha1/nemo_datastore_types.go Show resolved Hide resolved

api/apps/v1alpha1/nemo_datastore_types.go Outdated Show resolved Hide resolved

api/apps/v1alpha1/nemo_datastore_types.go Show resolved Hide resolved

shengnuo force-pushed the dsv2 branch from 29b27f6 to 394ebd5 Compare

January 24, 2025 18:51


          Add objectStore and ExternalDatabase fields to datastore .spec

3346bbd

Signed-off-by: Sheng Lin <shelin@nvidia.com>

shengnuo force-pushed the dsv2 branch from 394ebd5 to 3346bbd Compare

January 24, 2025 18:52

visheshtanksale approved these changes

View reviewed changes

Collaborator

visheshtanksale left a comment

LGTM

shivamerla approved these changes

View reviewed changes

Collaborator

shivamerla left a comment

looks good

shivamerla merged commit 329298c into NVIDIA:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

varunrsekar varunrsekar left review comments

visheshtanksale visheshtanksale approved these changes

shivamerla shivamerla approved these changes

ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

+1 more reviewer

slu2011 slu2011 left review comments

Labels

None yet