Skip to content

Fix PVC creation with an empty storage class name #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visheshtanksale merged 1 commit into from
Feb 28, 2025
Merged

Fix PVC creation with an empty storage class name #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions internal/shared/pvc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,11 @@ import (

// ConstructPVC constructs a PVC from the custom spec from the user
func ConstructPVC(pvc appsv1alpha1.PersistentVolumeClaim, pvcMeta metav1.ObjectMeta) (*corev1.PersistentVolumeClaim, error) {
storageClassName := pvc.StorageClass
size, err := resource.ParseQuantity(pvc.Size)
if err != nil {
return nil, fmt.Errorf("failed to parse size for pvc creation %s, err %v", pvcMeta.Name, err)
}
return &corev1.PersistentVolumeClaim{
claim := &corev1.PersistentVolumeClaim{
ObjectMeta: pvcMeta,
Spec: corev1.PersistentVolumeClaimSpec{
AccessModes: []corev1.PersistentVolumeAccessMode{pvc.VolumeAccessMode},
Expand All @@ -41,7 +40,12 @@ func ConstructPVC(pvc appsv1alpha1.PersistentVolumeClaim, pvcMeta metav1.ObjectM
corev1.ResourceStorage: size,
},
},
StorageClassName: &storageClassName,
},
}, nil
}

if pvc.StorageClass != "" {
claim.Spec.StorageClassName = &pvc.StorageClass
}

return claim, nil
}