Skip to content

Bump NeMo datastore version #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivamerla merged 4 commits into from
Mar 6, 2025
Merged

Bump NeMo datastore version #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8acecfc
Bump NeMo datastore version
shivamerla Mar 4, 2025
41649e6
Fix probe endpoint and pg secret key
shivamerla Mar 4, 2025
7fd3d5a
Use nemo namespace by default in the sample CR
shivamerla Mar 5, 2025
df02108
Remove the duplicate sample file for NeMo datastore service
shivamerla Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/apps/v1alpha1/nemo_datastore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ func (n *NemoDatastore) GetDefaultLivenessProbe() *corev1.Probe {
FailureThreshold: 3,
ProbeHandler: corev1.ProbeHandler{
HTTPGet: &corev1.HTTPGetAction{
Path: "/v1/health/live",
Comment thread
shengnuo marked this conversation as resolved.
Path: "/v1/health",
Port: intstr.IntOrString{
Type: intstr.Type(0),
IntVal: n.Spec.Expose.Service.Port,
Expand Down Expand Up @@ -621,7 +621,7 @@ func (n *NemoDatastore) GetDefaultReadinessProbe() *corev1.Probe {
FailureThreshold: 3,
ProbeHandler: corev1.ProbeHandler{
HTTPGet: &corev1.HTTPGetAction{
Path: "/v1/health/ready",
Path: "/v1/health",
Port: intstr.IntOrString{
Type: intstr.Type(0),
IntVal: n.Spec.Expose.Service.Port,
Expand All @@ -648,7 +648,7 @@ func (n *NemoDatastore) GetDefaultStartupProbe() *corev1.Probe {
FailureThreshold: 180,
ProbeHandler: corev1.ProbeHandler{
HTTPGet: &corev1.HTTPGetAction{
Path: "/v1/health/ready",
Path: "/v1/health",
Port: intstr.IntOrString{
Type: intstr.Type(0),
IntVal: n.Spec.Expose.Service.Port,
Expand Down
38 changes: 7 additions & 31 deletions config/samples/apps_v1alpha1_nemodatastore.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ kind: NemoDatastore
metadata:
labels:
app.kubernetes.io/name: k8s-nim-operator
app.kubernetes.io/managed-by: kustomize
app.kubernetes.io/managed-by: k8s-nim-operator
name: nemodatastore-sample
namespace: nemo
spec:
authSecret: ngc-image-pull-secret
authSecret: ngc-secret
secrets:
datastoreConfigSecret: "nemo-ms-nemo-datastore"
datastoreInitSecret: "nemo-ms-nemo-datastore-init"
Expand All @@ -19,16 +20,16 @@ spec:
secretName: nds-minio-existing-secret
passwordKey: objectStoreSecret
serveDirect: true
endpoint: minio.k8s-nim-operator-system.svc.cluster.local:9000
endpoint: minio.nemo.svc.cluster.local:9000
bucketName: datastore-dev
region: object-store-region
ssl: false
databaseConfig:
credentials:
user: ndsuser
secretName: nds-pg-existing-secret
passwordKey: postgresPassword
host: nds-pg-postgresql
passwordKey: password
host: nds-pg-postgresql.nemo.svc.cluster.local
port: 5432
databaseName: ndsdb
pvc:
Expand All @@ -43,7 +44,7 @@ spec:
type: ClusterIP
image:
repository: "nvcr.io/nvidian/nemo-llm/datastore"
tag: "25.01-rc8"
tag: "25.03-rc11"
pullPolicy: IfNotPresent
replicas: 1
resources:
Expand All @@ -53,28 +54,3 @@ spec:
limits:
memory: "512Mi"
cpu: "1"
livenessProbe:
enabled: true
probe:
httpGet:
path: /v1/health
port: 3000
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 5
readinessProbe:
enabled: true
probe:
httpGet:
path: /v1/health
port: 3000
scheme: HTTP
initialDelaySeconds: 5
timeoutSeconds: 3
# metrics:
# enabled: true
# serviceMonitor:
# additionalLabels:
# app: sample-nemodatastore
# interval: "30s"
# scrapeTimeout: "10s"
77 changes: 0 additions & 77 deletions config/samples/apps_v1alpha1_nimdatastore.yaml
View file
Open in desktop

This file was deleted.