Add image pull secrets to nemodatastore CR sample and remove authSecret from NeMoDatastore Spec#362
Merged
shivamerla merged 2 commits intoNVIDIA:mainfrom Mar 13, 2025
Merged
Conversation
shengnuo
requested review from
ArangoGutierrez,
shivamerla,
slu2011,
varunrsekar and
visheshtanksale
as code owners
shengnuo
force-pushed
the
datastore-sample-ips
branch
from
2da486f to
4e06af5
Compare
shivamerla
reviewed
Mar 7, 2025
shengnuo
force-pushed
the
datastore-sample-ips
branch
2 times, most recently
from
dca71d7 to
09cedcd
Compare
shengnuo
changed the title
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
shivamerla
force-pushed
the
datastore-sample-ips
branch
from
09cedcd to
9746ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.