Skip to content

Fix Milvus installation in OpenShift #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivamerla merged 1 commit into from
Mar 13, 2025
Merged

Fix Milvus installation in OpenShift #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions test/e2e/nemo-dependencies/evaluator/tasks/milvus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
---
- name: Get Kube API resources
command: kubectl api-resources --verbs=list --namespaced -o name
register: api_resources

- name: Check if the current cluster is OpenShift
set_fact:
is_openshift: "{{ 'routes.route.openshift.io' in api_resources.stdout_lines }}"

- name: OpenShift - Create Milvus service account
command: kubectl create serviceaccount milvus -n {{ namespace }}
when: is_openshift

- name: OpenShift - Add SCC policy anyuid to Milvus service account
command: oc adm policy add-scc-to-user anyuid system:serviceaccount:{{ namespace }}:milvus
when: is_openshift

- name: Add Helm repository for Milvus
command: helm repo add {{ milvus.helm_repo_name }} {{ milvus.helm_repo_url }}

Expand All @@ -10,6 +26,17 @@
src: milvus-values.yaml.j2
dest: milvus-values.yaml

- name: OpenShift - configure Milvus to use its dedicated service account
blockinfile:
path: milvus-values.yaml
marker: "# {mark} ANSIBLE MANAGED BLOCK"
insertafter: "^(.*)$"
block: |
serviceAccount:
create: false
name: milvus
when: is_openshift

- name: Install Milvus Helm chart
shell: >
helm upgrade --install {{ milvus.helm_repo_name }}
Expand Down
4 changes: 4 additions & 0 deletions test/e2e/nemo-dependencies/evaluator/tasks/uninstall.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,7 @@
loop:
- crd
ignore_errors: true

- name: Delete Milvus SA
command: kubectl delete serviceaccount milvus -n {{ namespace }}
ignore_errors: true