Merged
Conversation
Collaborator
varunrsekar
commented
Mar 12, 2025
varunrsekar
commented
- fix default probe endpoints
- create guardrails configstore PVC if requested
- abstract out configstore configMap into a separate object and validate its not provided along with PVC.
varunrsekar
requested review from
ArangoGutierrez,
shengnuo,
shivamerla,
slu2011 and
visheshtanksale
as code owners
shivamerla
reviewed
Mar 13, 2025
shivamerla
reviewed
Mar 13, 2025
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
varunrsekar
force-pushed
the
guardrails-pvc
branch
from
ce7d72c to
5cac996
Compare
shivamerla
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.