Closed
Conversation
Removing the e2e test workflow since this does not provide a reasonable signal of health. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
ArangoGutierrez,
shengnuo,
shivamerla,
slu2011,
varunrsekar and
visheshtanksale
as code owners
varunrsekar
requested changes
Mar 19, 2025
| jobs: | ||
| e2e-tests: | ||
| runs-on: linux-amd64-cpu4 | ||
| if: ${{ github.event.workflow_run.conclusion == 'success' }} && ${{ github.event.workflow_run.event == 'push' }} |
Collaborator
There was a problem hiding this comment.
if: false # TODO: Disabled until e2e tests is made stable
Can you instead comment this line and replace with the above?
Collaborator
|
thanks @elezar we didn't get to check the errors with EC2 provisioning. @ArangoGutierrez any idea why |
Collaborator
|
closing this as this is disabled with #411 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the e2e test workflow since this does not provide a reasonable signal of health.
The e2e tests always fail (https://github.com/NVIDIA/k8s-nim-operator/actions/workflows/e2e.yml) and do not provide a reasonable signal of health. If these are readded, they should be configured so as to run per PR.