Allow custom scheduler to be specified in NIMService and NIMPipeline#489
Merged
shengnuo merged 3 commits intoNVIDIA:mainfrom May 16, 2025
Merged
Allow custom scheduler to be specified in NIMService and NIMPipeline#489shengnuo merged 3 commits intoNVIDIA:mainfrom
shengnuo merged 3 commits intoNVIDIA:mainfrom
Conversation
ba431f6 to
9156d33
Compare
varunrsekar
reviewed
May 12, 2025
Collaborator
visheshtanksale
left a comment
There was a problem hiding this comment.
Is there any value around having some global config that will set the scheduler for all the pods created by NIM Operator?
Having scheduler on the CRDs is necessary. But it is not a value thats going to change across multiple objects created using NIM Operator, so having a global config makes it easy to use
2cf6f6e to
ff6291f
Compare
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
ff6291f to
827617b
Compare
varunrsekar
pushed a commit
to varunrsekar/k8s-nim-operator
that referenced
this pull request
May 20, 2025
…ler (NVIDIA#489) Signed-off-by: Sheng Lin <shelin@nvidia.com> Update manifests Signed-off-by: Sheng Lin <shelin@nvidia.com>
varunrsekar
pushed a commit
that referenced
this pull request
May 20, 2025
…ler (#489) Signed-off-by: Sheng Lin <shelin@nvidia.com> Update manifests Signed-off-by: Sheng Lin <shelin@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds allows NIMs to be scheduled with a custom scheduler.
.spec.services[].spec.schedulerNamefor NIMPipeline; and in.spec.schedulerNamefor NIMServices.default-schedulerif the.schedulerNameis unspecifiedScheduled with Volcano
Describing the created NIM pod, we can see that the pod was scheduled with Volcano
Scheduled with default-scheduler
If the scheduler is unspecified, NIM operator will choose the
default-scheduleras default.Describing the NIM pod, we can see that the pod was scheduled with default-scheduler