Add optional grpc,metrics ports to NIMService#490
Merged
varunrsekar merged 3 commits intoNVIDIA:mainfrom May 14, 2025
Merged
Conversation
varunrsekar
requested review from
ArangoGutierrez,
shengnuo,
shivamerla,
slu2011 and
visheshtanksale
as code owners
varunrsekar
changed the title
varunrsekar
force-pushed
the
add-svc-ports
branch
from
7c3f5b1 to
7ed29b9
Compare
shivamerla
reviewed
May 13, 2025
shivamerla
reviewed
May 13, 2025
shivamerla
approved these changes
May 13, 2025
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
varunrsekar
force-pushed
the
add-svc-ports
branch
from
7ed29b9 to
ee41789
Compare
varunrsekar
added a commit
to varunrsekar/k8s-nim-operator
that referenced
this pull request
May 14, 2025
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com> new port validations for nemo microservice CRs Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com> update rag pipeline sample with additional ports Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
varunrsekar
added a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com> new port validations for nemo microservice CRs Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com> update rag pipeline sample with additional ports Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces 2 new ports to the NIMService API spec:
spec.expose.service.grpcPort: sets the application envNIM_TRITION_GRPC_PORTspec.expose.service.metricsPort: sets the application envNIM_TRITON_METRICS_PORT