Allow configurable sizeLimit for shared memory (emptyDir) Volumes#492
Merged
shengnuo merged 2 commits intoNVIDIA:mainfrom May 13, 2025
Merged
Allow configurable sizeLimit for shared memory (emptyDir) Volumes#492shengnuo merged 2 commits intoNVIDIA:mainfrom
shengnuo merged 2 commits intoNVIDIA:mainfrom
Conversation
shengnuo
requested review from
ArangoGutierrez,
shivamerla,
slu2011,
varunrsekar and
visheshtanksale
as code owners
shengnuo
changed the title
shengnuo
force-pushed
the
empty-dir-size-limit
branch
from
9c0e136 to
d6652e8
Compare
shivamerla
reviewed
May 13, 2025
shivamerla
reviewed
May 13, 2025
shivamerla
reviewed
May 13, 2025
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
shengnuo
force-pushed
the
empty-dir-size-limit
branch
from
d6652e8 to
2d6ae9d
Compare
shivamerla
approved these changes
May 13, 2025
Collaborator
|
@shengnuo please cherry-pick to release branch. |
Collaborator
Author
|
#493 PR to release-2.0 branch |
shengnuo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the size of emptyDir volumes to be limited
.spec.storage.sharedMemorySizeLimitfor NIMServices; and in.spec.services[].spec.storage.sharedMemorySizeLimitfor NIMPipelines.spec.trainingConfig.sharedMemorySizeLimit