Skip to content

fix model status for NIMs incompatible with openapi schema#498

Merged
varunrsekar merged 1 commit intoNVIDIA:mainfrom
varunrsekar:model-status
May 20, 2025
Merged

fix model status for NIMs incompatible with openapi schema#498
varunrsekar merged 1 commit intoNVIDIA:mainfrom
varunrsekar:model-status

Conversation

@varunrsekar
Copy link
Copy Markdown
Collaborator

Fallback to using /v1/metadata API endpoint to get the model name for NIMs incompatible with openapi schema

The workflow:

  • Try /v1/models API
  • if it errors out with a 404 HTTP error, then use /v1/metadata API

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Copy Markdown
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
@varunrsekar varunrsekar merged commit b630bd8 into NVIDIA:main May 20, 2025
9 checks passed
@varunrsekar varunrsekar deleted the model-status branch May 20, 2025 16:35
varunrsekar added a commit to varunrsekar/k8s-nim-operator that referenced this pull request May 20, 2025
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
varunrsekar added a commit that referenced this pull request May 20, 2025
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
@a-mccarthy
Copy link
Copy Markdown

@varunrsekar are there any customer impact of docs updates needed for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants