Skip to content

Replace the deprecated backend with model_type tags for non LLM nims #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visheshtanksale merged 3 commits into from
May 30, 2025
Merged

Replace the deprecated backend with model_type tags for non LLM nims #513

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91b6793
Replace the deprecated backend with model_type tags for non LLM nims
visheshtanksale May 30, 2025
ebe068b
Replace the deprecated backend with model_type tags for non LLM nims
visheshtanksale May 30, 2025
0104166
Addressing review comments
visheshtanksale May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal/nimparser/v2/nimparser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,15 @@ func (manifest NIMManifest) MatchProfiles(modelSpec appsv1alpha1.ModelSpec, disc
// Determine backend type
backend := profile.Tags["llm_engine"]
if backend == "" {
backend = profile.Tags["backend"]
// model_type is used for non llm models
backend = profile.Tags["model_type"]
if backend == "" {
// Fallback to backend tag if model_type is not set. Backend tag is deprecated.
backend = profile.Tags["backend"]
if backend == "triton" {
backend = "tensorrt"
}
}
Comment thread
shivamerla marked this conversation as resolved.
Outdated
}

if modelSpec.Engine != "" && !strings.Contains(backend, strings.TrimSuffix(modelSpec.Engine, "_llm")) {
Expand Down
Loading