Skip to content

Change yaml package to sigs.k8s.io/yaml#522

Merged
shivamerla merged 1 commit intoNVIDIA:mainfrom
shengnuo:change-yaml-pkg
Jun 5, 2025
Merged

Change yaml package to sigs.k8s.io/yaml#522
shivamerla merged 1 commit intoNVIDIA:mainfrom
shengnuo:change-yaml-pkg

Conversation

@shengnuo
Copy link
Copy Markdown
Collaborator

@shengnuo shengnuo commented Jun 4, 2025

No description provided.

Signed-off-by: Sheng Lin <shelin@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jun 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@varunrsekar
Copy link
Copy Markdown
Collaborator

What's the goal of this change? None of the yaml operations we do is with k8s objects. So wasnt sure why we need to replace them. A description will be helpful.

Also, if we do need this, we should eliminate the yaml tags in the structs of nimparser. Since the k8s yaml pkg works with the json tags.

@shivamerla
Copy link
Copy Markdown
Collaborator

What's the goal of this change? None of the yaml operations we do is with k8s objects. So wasnt sure why we need to replace them. A description will be helpful.

Also, if we do need this, we should eliminate the yaml tags in the structs of nimparser. Since the k8s yaml pkg works with the json tags.

@varunrsekar this is in the context of the issue we have seen when marshaling PodSecurityContext for customizer config. I think the change in nimparser is fine as well as we define both yaml and json tags there, so this won't break anything but will be consistent across.

Copy link
Copy Markdown
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamerla shivamerla merged commit 16ccde3 into NVIDIA:main Jun 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants