Skip to content

kubebuilder validations for DRAResources#527

Merged
varunrsekar merged 1 commit intoNVIDIA:mainfrom
varunrsekar:dra-api-validations
Jun 10, 2025
Merged

kubebuilder validations for DRAResources#527
varunrsekar merged 1 commit intoNVIDIA:mainfrom
varunrsekar:dra-api-validations

Conversation

@varunrsekar
Copy link
Copy Markdown
Collaborator

This change adds basic validation markers to the DRAResource api fields.

TODO:

  • Comprehensive validations via a webhook:
    • unique resource claim names
    • only resource claim templates should be specified when autoscaling is enabled or multiple replicas requested
    • reject spec.draResources[] for cluster versions < v1.33

Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jun 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@varunrsekar varunrsekar merged commit 27e0ff5 into NVIDIA:main Jun 10, 2025
9 checks passed
@varunrsekar varunrsekar deleted the dra-api-validations branch June 10, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants