Support basic multi-node NIMs with LeaderWorkerSet#528
Merged
shivamerla merged 5 commits intoNVIDIA:mainfrom Jun 30, 2025
Merged
Support basic multi-node NIMs with LeaderWorkerSet#528shivamerla merged 5 commits intoNVIDIA:mainfrom
shivamerla merged 5 commits intoNVIDIA:mainfrom
Conversation
shengnuo
requested review from
ArangoGutierrez,
shivamerla,
slu2011,
varunrsekar and
visheshtanksale
as code owners
shengnuo
force-pushed
the
lws
branch
5 times, most recently
from
a707333 to
fa43dfb
Compare
shengnuo
changed the title
shivamerla
reviewed
Jun 16, 2025
shivamerla
reviewed
Jun 16, 2025
shivamerla
reviewed
Jun 16, 2025
varunrsekar
requested changes
Jun 17, 2025
shengnuo
force-pushed
the
lws
branch
8 times, most recently
from
1d036ba to
b0cfe4f
Compare
varunrsekar
reviewed
Jun 18, 2025
shengnuo
force-pushed
the
lws
branch
5 times, most recently
from
4dce616 to
601009f
Compare
shivamerla
reviewed
Jun 25, 2025
shivamerla
reviewed
Jun 25, 2025
shivamerla
reviewed
Jun 25, 2025
varunrsekar
reviewed
Jun 26, 2025
Collaborator
varunrsekar
left a comment
varunrsekar
left a comment
There was a problem hiding this comment.
Overall looks good to me. Just some more api comments...
shengnuo
force-pushed
the
lws
branch
11 times, most recently
from
d977bbb to
0356f36
Compare
Signed-off-by: Sheng Lin <shelin@nvidia.com>
shivamerla
previously approved these changes
Jun 30, 2025
varunrsekar
previously approved these changes
Jun 30, 2025
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
shivamerla
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an early support of multi-node NIMs using LeaderWorkerSet.
In NIMService.spec, if
.multiNodeis specified and not nil, a LeaderWorkerSet will be created for the NIMService.